Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1088763003: Fix printf format specifier when printing FilePath (Closed)

Created:
5 years, 8 months ago by hans
Modified:
5 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix printf format specifier when printing FilePath Caught by Clang on Windows. BUG=82385 R=dalecurtis@chromium.org TBR=phoglund NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/1862ffcb911a6f8126b886057119300a8197035b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
hans
Please take a look.
5 years, 8 months ago (2015-04-22 20:31:29 UTC) #2
hans
tbr'ing phoglund since this is trivial and our bots are turning red because of it.
5 years, 8 months ago (2015-04-22 21:16:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088763003/1
5 years, 8 months ago (2015-04-22 21:16:46 UTC) #5
DaleCurtis
Didn't know PRFilePath was a thing, lgtm
5 years, 8 months ago (2015-04-22 21:24:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088763003/1
5 years, 8 months ago (2015-04-22 22:32:40 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1862ffcb911a6f8126b886057119300a8197035b Cr-Commit-Position: refs/heads/master@{#326386}
5 years, 8 months ago (2015-04-22 23:01:00 UTC) #10
hans
Committed patchset #1 (id:1) manually as 1862ffcb911a6f8126b886057119300a8197035b (presubmit successful).
5 years, 8 months ago (2015-04-22 23:01:21 UTC) #11
phoglund_chromium
5 years, 8 months ago (2015-04-23 08:10:56 UTC) #12
Message was sent while issue was closed.
On 2015/04/22 23:01:21, hans wrote:
> Committed patchset #1 (id:1) manually as
> 1862ffcb911a6f8126b886057119300a8197035b (presubmit successful).

Thank you very much for the fix! That's awesome. I'll make sure to do that right
next time :)

Powered by Google App Engine
This is Rietveld 408576698