Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Side by Side Diff: chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc

Issue 1088763003: Fix printf format specifier when printing FilePath (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ctime> 5 #include <ctime>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_enumerator.h" 8 #include "base/files/file_enumerator.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 base::FilePath filename; 475 base::FilePath filename;
476 EXPECT_TRUE(base::CreateTemporaryFile(&filename)); 476 EXPECT_TRUE(base::CreateTemporaryFile(&filename));
477 base::FilePath wav_filename = 477 base::FilePath wav_filename =
478 filename.AddExtension(FILE_PATH_LITERAL(".wav")); 478 filename.AddExtension(FILE_PATH_LITERAL(".wav"));
479 EXPECT_TRUE(base::Move(filename, wav_filename)); 479 EXPECT_TRUE(base::Move(filename, wav_filename));
480 return wav_filename; 480 return wav_filename;
481 } 481 }
482 482
483 void DeleteFileUnlessTestFailed(const base::FilePath& path, bool recursive) { 483 void DeleteFileUnlessTestFailed(const base::FilePath& path, bool recursive) {
484 if (::testing::Test::HasFailure()) 484 if (::testing::Test::HasFailure())
485 printf("Test failed; keeping recording(s) at\n\t%s.\n", 485 printf("Test failed; keeping recording(s) at\n\t%" PRFilePath ".\n",
486 path.value().c_str()); 486 path.value().c_str());
487 else 487 else
488 EXPECT_TRUE(base::DeleteFile(path, recursive)); 488 EXPECT_TRUE(base::DeleteFile(path, recursive));
489 } 489 }
490 490
491 std::vector<base::FilePath> ListWavFilesInDir(const base::FilePath& dir) { 491 std::vector<base::FilePath> ListWavFilesInDir(const base::FilePath& dir) {
492 base::FileEnumerator files(dir, false, base::FileEnumerator::FILES, 492 base::FileEnumerator files(dir, false, base::FileEnumerator::FILES,
493 FILE_PATH_LITERAL("*.wav")); 493 FILE_PATH_LITERAL("*.wav"));
494 494
495 std::vector<base::FilePath> result; 495 std::vector<base::FilePath> result;
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
786 } 786 }
787 787
788 // Since the AGC is off here there should be no gain at all. 788 // Since the AGC is off here there should be no gain at all.
789 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest, 789 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest,
790 MANUAL_TestAutoGainIsOffWithAudioProcessingOff) { 790 MANUAL_TestAutoGainIsOffWithAudioProcessingOff) {
791 const char* kAudioCallWithoutAudioProcessing = 791 const char* kAudioCallWithoutAudioProcessing =
792 "{audio: { mandatory: { echoCancellation: false } } }"; 792 "{audio: { mandatory: { echoCancellation: false } } }";
793 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl( 793 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl(
794 kReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc")); 794 kReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc"));
795 } 795 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698