Adding v8_isolate_memory_dump_provider.

gin/isolate_holder.cc

Index: gin/isolate_holder.cc
diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc
index 6081a0b4b106a6e61744efc6f162c715c8764d73..5c1f5788b8502b2401ee127b68f7d231f7781a5a 100644
--- a/gin/isolate_holder.cc
+++ b/gin/isolate_holder.cc
@@ -15,6 +15,7 @@
 #include "gin/per_isolate_data.h"
 #include "gin/run_microtasks_observer.h"
 #include "gin/v8_initializer.h"
+#include "gin/v8_isolate_memory_dump_provider.h"
 
 namespace gin {
 
@@ -32,6 +33,7 @@ IsolateHolder::IsolateHolder() {
                                        base::SysInfo::AmountOfVirtualMemory(),
                                        base::SysInfo::NumberOfProcessors());
   isolate_ = v8::Isolate::New(params);
+  isolate_memory_dump_provider_.reset(new V8IsolateMemoryDumpProvider(this));

[Primiano Tucci (use gerrit), 2015/04/17 19:10:30]

I am not sure what isolate_data is, but feel safer that you create this at the
very end of this CTOR.

   isolate_data_.reset(new PerIsolateData(isolate_, allocator));
 #if defined(OS_WIN)
   {
@@ -61,6 +63,7 @@ IsolateHolder::~IsolateHolder() {
   }
 #endif
   isolate_data_.reset();
+  isolate_memory_dump_provider_.reset();

[Primiano Tucci (use gerrit), 2015/04/17 19:10:30]

symmetrically, move this at the very first

   isolate_->Dispose();
   isolate_ = NULL;
 }