Adding v8_isolate_memory_dump_provider.

gin/isolate_holder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/public/isolate_holder.h"
 
 #include <stdlib.h>
 #include <string.h>
 
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/sys_info.h"
 #include "gin/debug_impl.h"
 #include "gin/function_template.h"
 #include "gin/per_isolate_data.h"
 #include "gin/run_microtasks_observer.h"
 #include "gin/v8_initializer.h"
+#include "gin/v8_isolate_memory_dump_provider.h"
 
 namespace gin {
 
 namespace {
 v8::ArrayBuffer::Allocator* g_array_buffer_allocator = nullptr;
 }  // namespace
 
 IsolateHolder::IsolateHolder() {
   v8::ArrayBuffer::Allocator* allocator = g_array_buffer_allocator;
   CHECK(allocator) << "You need to invoke gin::IsolateHolder::Initialize first";
   v8::Isolate::CreateParams params;
   params.entry_hook = DebugImpl::GetFunctionEntryHook();
   params.code_event_handler = DebugImpl::GetJitCodeEventHandler();
   params.constraints.ConfigureDefaults(base::SysInfo::AmountOfPhysicalMemory(),
                                        base::SysInfo::AmountOfVirtualMemory(),
                                        base::SysInfo::NumberOfProcessors());
   isolate_ = v8::Isolate::New(params);
+  isolate_memory_dump_provider_.reset(new V8IsolateMemoryDumpProvider(this));

[Primiano Tucci (use gerrit), 2015/04/17 19:10:30]

I am not sure what isolate_data is, but feel safer that you create this at the
very end of this CTOR.

   isolate_data_.reset(new PerIsolateData(isolate_, allocator));
 #if defined(OS_WIN)
   {
     void* code_range;
     size_t size;
     isolate_->GetCodeRange(&code_range, &size);
     Debug::CodeRangeCreatedCallback callback =
         DebugImpl::GetCodeRangeCreatedCallback();
     if (code_range && size && callback)
       callback(code_range, size);
   }
 #endif
 }
 
 IsolateHolder::~IsolateHolder() {
   if (task_observer_.get())
     base::MessageLoop::current()->RemoveTaskObserver(task_observer_.get());
 #if defined(OS_WIN)
   {
     void* code_range;
     size_t size;
     isolate_->GetCodeRange(&code_range, &size);
     Debug::CodeRangeDeletedCallback callback =
         DebugImpl::GetCodeRangeDeletedCallback();
     if (code_range && callback)
       callback(code_range);
   }
 #endif
   isolate_data_.reset();
+  isolate_memory_dump_provider_.reset();

[Primiano Tucci (use gerrit), 2015/04/17 19:10:30]

symmetrically, move this at the very first

   isolate_->Dispose();
   isolate_ = NULL;
 }
 
 // static
 void IsolateHolder::Initialize(ScriptMode mode,
                                v8::ArrayBuffer::Allocator* allocator) {
   CHECK(allocator);
   gin::V8Initializer::Initialize(mode, allocator);
   g_array_buffer_allocator = allocator;
 }
 
 void IsolateHolder::AddRunMicrotasksObserver() {
   DCHECK(!task_observer_.get());
   task_observer_.reset(new RunMicrotasksObserver(isolate_));;
   base::MessageLoop::current()->AddTaskObserver(task_observer_.get());
 }
 
 void IsolateHolder::RemoveRunMicrotasksObserver() {
   DCHECK(task_observer_.get());
   base::MessageLoop::current()->RemoveTaskObserver(task_observer_.get());
   task_observer_.reset();
 }
 
 }  // namespace gin