Fix crash when a webview tries to load a plugin resource.

Fix crash when a webview tries to load a plugin resource.

BUG=477148
TEST=Load webview browser sample (https://chrome.google.com/webstore/detail/browser-sample/edggnmnajhcbhlnpjnogkjpghaikidaa), use the browser sample app to navigate to a website that embeds a plugin (flash or pdf). Verify that the browser doesn't crash.

Committed: https://crrev.com/44c8a68f7c44d5af478717704a508aeaa2a15610
Cr-Commit-Position: refs/heads/master@{#325454}

[lfg, 2015-04-15 19:10:24]

lfg@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lfg, 2015-04-15 19:10:24]

PTAL, thanks!

[lazyboy, 2015-04-15 19:18:27]

LGTM % one nit

https://codereview.chromium.org/1088323002/diff/1/chrome/browser/apps/guest_v...
File chrome/browser/apps/guest_view/web_view_browsertest.cc (right):

https://codereview.chromium.org/1088323002/diff/1/chrome/browser/apps/guest_v...
chrome/browser/apps/guest_view/web_view_browsertest.cc:2752: // This test tests
that webview won't crash when trying to load plugin
nit:
// Tests that browser process does not crash when loading plugin
// inside <webview> with content settings set to CONTENT..

[lfg, 2015-04-15 19:22:32]

https://codereview.chromium.org/1088323002/diff/1/chrome/browser/apps/guest_v...
File chrome/browser/apps/guest_view/web_view_browsertest.cc (right):

https://codereview.chromium.org/1088323002/diff/1/chrome/browser/apps/guest_v...
chrome/browser/apps/guest_view/web_view_browsertest.cc:2752: // This test tests
that webview won't crash when trying to load plugin
On 2015/04/15 19:18:27, lazyboy wrote:
> nit:
> // Tests that browser process does not crash when loading plugin
> // inside <webview> with content settings set to CONTENT..

Done.

[lfg, 2015-04-15 19:23:12]

lfg@chromium.org changed reviewers:
+ bauerb@chromium.org

[lfg, 2015-04-15 19:23:12]

bauerb@chromium.org: Please review changes in 

chrome/browser/plugins/plugin_info_message_filter.cc


Thanks!

[Bernhard Bauer, 2015-04-16 08:02:20]

LGTM w/ a nit:

https://codereview.chromium.org/1088323002/diff/20001/chrome/browser/plugins/...
File chrome/browser/plugins/plugin_info_message_filter.cc (right):

https://codereview.chromium.org/1088323002/diff/20001/chrome/browser/plugins/...
chrome/browser/plugins/plugin_info_message_filter.cc:161: const
extensions::WebviewInfo* webview_info =
Nit: I would return before this line if |extension| is null, so you don't need
the five-line ?: expression.

[lfg, 2015-04-16 15:03:33]

https://codereview.chromium.org/1088323002/diff/20001/chrome/browser/plugins/...
File chrome/browser/plugins/plugin_info_message_filter.cc (right):

https://codereview.chromium.org/1088323002/diff/20001/chrome/browser/plugins/...
chrome/browser/plugins/plugin_info_message_filter.cc:161: const
extensions::WebviewInfo* webview_info =
On 2015/04/16 08:02:20, Bernhard Bauer wrote:
> Nit: I would return before this line if |extension| is null, so you don't need
> the five-line ?: expression.

Done.

[lfg, 2015-04-16 15:55:56]

The CQ bit was checked by lfg@chromium.org

[lfg, 2015-04-16 15:55:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1088323002/#ps40001
(title: "addressing comments")

[commit-bot: I haz the power, 2015-04-16 15:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1088323002/40001

[commit-bot: I haz the power, 2015-04-16 16:38:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-16 16:39:13]

Patchset 3 (id:??) landed as
https://crrev.com/44c8a68f7c44d5af478717704a508aeaa2a15610
Cr-Commit-Position: refs/heads/master@{#325454}