Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 1088323002: Fix crash when a webview tries to load a plugin resource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/embed.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
index 1ef5637d869eca9ceada3d7b371cc770e1000795..b272b29a8cb01ac0bb47bd96492cd6b7e0138fdd 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
@@ -32,6 +32,8 @@ embedder.setUp_ = function(config) {
embedder.testImageBaseURL = embedder.baseGuestURL +
'/extensions/platform_apps/web_view/shim/';
embedder.virtualURL = 'http://virtualurl/';
+ embedder.pluginURL = embedder.baseGuestURL +
+ '/extensions/platform_apps/web_view/shim/embed.html';
};
window.runTest = function(testName) {
@@ -2205,6 +2207,16 @@ function testDisabledZoomMode() {
document.body.appendChild(webview);
}
+function testPlugin() {
+ var webview = document.createElement('webview');
+ webview.setAttribute('src', embedder.pluginURL);
+ webview.addEventListener('loadstop', function(e) {
+ // Not crashing means success.
+ embedder.test.succeed();
+ });
+ document.body.appendChild(webview);
+}
+
embedder.test.testList = {
'testAllowTransparencyAttribute': testAllowTransparencyAttribute,
'testAutosizeHeight': testAutosizeHeight,
@@ -2287,6 +2299,7 @@ embedder.test.testList = {
'testPerOriginZoomMode': testPerOriginZoomMode,
'testPerViewZoomMode': testPerViewZoomMode,
'testDisabledZoomMode': testDisabledZoomMode,
+ 'testPlugin': testPlugin,
};
onload = function() {
« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/embed.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698