Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1088163002: Analyzer didn't match correctly targets that defined path to inputs with '.' (Closed)

Created:
5 years, 8 months ago by kindrik
Modified:
5 years, 4 months ago
Reviewers:
Mark Mentovai, sky
CC:
gyp-developer_googlegroups.com
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Analyzer didn't match correctly targets that defined path to inputs with '.' relative path values. So let normalize path before matching. BUG=gyp:487 TEST=covered by tests R=mark@chromium.org, sky@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/edccc7bad7dac8f608748770faed19f849114804

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased to fresh master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M pylib/gyp/generator/analyzer.py View 1 1 chunk +1 line, -1 line 0 comments Download
M test/analyzer/gyptest-analyzer.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/analyzer/test.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kindrik
5 years, 8 months ago (2015-04-15 14:40:29 UTC) #1
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 8 months ago (2015-04-15 14:46:34 UTC) #6
kindrik
So let do this! This is my first ever contribution to chromium. Please don't be ...
5 years, 8 months ago (2015-04-15 14:53:24 UTC) #7
sky
https://codereview.chromium.org/1088163002/diff/1/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/1088163002/diff/1/pylib/gyp/generator/analyzer.py#newcode115 pylib/gyp/generator/analyzer.py:115: if source.startswith('../'): I wonder if we should special case ...
5 years, 8 months ago (2015-04-27 15:05:53 UTC) #8
Mark Mentovai
This seems fine. LGTM.
5 years, 7 months ago (2015-04-28 12:37:19 UTC) #9
kindrik
On 2015/04/28 12:37:19, Mark Mentovai - out til August wrote: > This seems fine. LGTM. ...
5 years, 4 months ago (2015-08-19 13:06:52 UTC) #10
Dirk Pranke
5 years, 4 months ago (2015-08-19 18:54:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
edccc7bad7dac8f608748770faed19f849114804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698