pylib/gyp/generator/analyzer.py - Issue 1088163002: Analyzer didn't match correctly targets that defined path to inputs with '.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/analyzer.py

Issue 1088163002: Analyzer didn't match correctly targets that defined path to inputs with '.' (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: Rebased to fresh master. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/analyzer.py

diff --git a/pylib/gyp/generator/analyzer.py b/pylib/gyp/generator/analyzer.py

index 3a0ec9baff27860bd23b084d152749e347a72dc7..16bff961ec499c29225df02d4df0e6971935b219 100644

--- a/pylib/gyp/generator/analyzer.py

+++ b/pylib/gyp/generator/analyzer.py

@@ -338,7 +338,7 @@ def _GenerateTargets(data, target_list, target_dicts, toplevel_dir, files,

sources = _ExtractSources(target_name, target_dicts[target_name],

toplevel_dir)

for source in sources:

- if source in files:

+ if os.path.normpath(source) in files:

print 'target', target_name, 'matches', source

target.match_status = MATCH_STATUS_MATCHES

matching_targets.append(target)

« no previous file with comments | « no previous file | test/analyzer/gyptest-analyzer.py » ('j') | no next file with comments »