Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 1087903003: Fix browser crash on shutdown when ProfileImplIOData::Handle::Init isn't called. (Closed)

Created:
5 years, 8 months ago by jeremyim
Modified:
5 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

Fix browser crash on shutdown when ProfileImplIOData::Handle::Init isn't called. With ephemeral profiles, in some cases, a Handle will be created and destroyed without being initialized. Root cause of why the object is created is still not known, but this change prevents the crash from occurring. BUG=478215 Review URL: https://codereview.chromium.org/1072143003 Cr-Commit-Position: refs/heads/master@{#326371} (cherry picked from commit 08f40f1daf017ec5ca8a0e6e6b977ab33bff69f9) Committed: https://chromium.googlesource.com/chromium/src/+/1a40423aeccc0b1ae7bebb6a1e3a62ac7b91b52b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jeremyim
5 years, 8 months ago (2015-04-24 18:27:45 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a40423aeccc0b1ae7bebb6a1e3a62ac7b91b52b.

Powered by Google App Engine
This is Rietveld 408576698