Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1072143003: Fix browser crash on shutdown when ProfileImplIOData::Handle::Init isn't called. (Closed)

Created:
5 years, 8 months ago by jeremyim
Modified:
5 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix browser crash on shutdown when ProfileImplIOData::Handle::Init isn't called. With ephemeral profiles, in some cases, a Handle will be created and destroyed without being initialized. Root cause of why the object is created is still not known, but this change prevents the crash from occurring. BUG=478215 Committed: https://crrev.com/08f40f1daf017ec5ca8a0e6e6b977ab33bff69f9 Cr-Commit-Position: refs/heads/master@{#326371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jeremyim
PTAL. Thanks! =)
5 years, 8 months ago (2015-04-22 20:07:04 UTC) #2
mmenke
On 2015/04/22 20:07:04, jeremyim wrote: > PTAL. Thanks! =) LGTM
5 years, 8 months ago (2015-04-22 20:09:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072143003/1
5 years, 8 months ago (2015-04-22 20:19:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 20:56:24 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 20:57:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08f40f1daf017ec5ca8a0e6e6b977ab33bff69f9
Cr-Commit-Position: refs/heads/master@{#326371}

Powered by Google App Engine
This is Rietveld 408576698