Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: third_party/sudden_motion_sensor/BUILD.gn

Issue 1087873003: Fix errors found in Mac gn component builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix libcontent Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sync.gyp ('k') | ui/accelerated_widget_mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sudden_motion_sensor/BUILD.gn
diff --git a/device/bluetooth/uribeacon/BUILD.gn b/third_party/sudden_motion_sensor/BUILD.gn
similarity index 65%
copy from device/bluetooth/uribeacon/BUILD.gn
copy to third_party/sudden_motion_sensor/BUILD.gn
index 0c7d1d8073cdf99aa48c2acd5f125228594f9837..5791fb8a68aa1632d4e319fb46b33ed5342e9fe8 100644
--- a/device/bluetooth/uribeacon/BUILD.gn
+++ b/third_party/sudden_motion_sensor/BUILD.gn
@@ -2,12 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-component("uribeacon") {
- sources = [
- "uri_encoder.cc",
- "uri_encoder.h",
- ]
+static_library("sudden_motion_sensor") {
brettw 2015/04/15 19:01:06 This should be a source_set.
Jiang Jiang 2015/04/15 20:21:26 Done. Is there a rule of thumb for choosing source
brettw 2015/04/16 17:04:18 Yes, use source_set unless there's a good reason n
deps = [
"//base",
]
+ sources = [
brettw 2015/04/15 19:01:06 GN style is to put the source first.
Jiang Jiang 2015/04/15 20:21:26 Done.
+ "sudden_motion_sensor_mac.cc",
+ "sudden_motion_sensor_mac.h",
+ ]
}
« no previous file with comments | « sync/sync.gyp ('k') | ui/accelerated_widget_mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698