third_party/sudden_motion_sensor/BUILD.gn - Issue 1087873003: Fix errors found in Mac gn component builds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/sudden_motion_sensor/BUILD.gn

Issue 1087873003: Fix errors found in Mac gn component builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix libcontent Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 component("uribeacon") {	5 static_library("sudden_motion_sensor") {
	brettw 2015/04/15 19:01:06 This should be a source_set. This should be a source_set. Jiang Jiang 2015/04/15 20:21:26 Done. Is there a rule of thumb for choosing source Show quoted text On 2015/04/15 19:01:06, brettw wrote: > This should be a source_set. Done. Is there a rule of thumb for choosing source_set vs. static_library? brettw 2015/04/16 17:04:18 Yes, use source_set unless there's a good reason n Yes, use source_set unless there's a good reason not to. The only real reason not to is that something depends on the specific static library symbol resolution rules.
6 sources = [

7 "uri_encoder.cc",

8 "uri_encoder.h",

9 ]

10 deps = [	6 deps = [

11 "//base",	7 "//base",

12 ]	8 ]

	9 sources = [
	brettw 2015/04/15 19:01:06 GN style is to put the source first. GN style is to put the source first. Jiang Jiang 2015/04/15 20:21:26 Done. Show quoted text On 2015/04/15 19:01:06, brettw wrote: > GN style is to put the source first. Done.
	10 "sudden_motion_sensor_mac.cc",

	11 "sudden_motion_sensor_mac.h",

	12 ]

13 }	13 }

OLD	NEW

« no previous file with comments | « sync/sync.gyp ('k') | ui/accelerated_widget_mac/BUILD.gn » ('j') | no next file with comments »