Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1087793002: [turbofan] add MachineType to AllocatedOperand (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] add MachineType to AllocatedOperand - allows the optimization of emitted gap move code since the representation of the value in the register is known - necessary preparation for vector register allocation - prepare for slot sharing for any value of the same byte width BUG= Committed: https://crrev.com/3a025d1ab6437559f86a464767aa03d2d9789f6f Cr-Commit-Position: refs/heads/master@{#28137}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Total comments: 1

Patch Set 17 : no flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -347 lines) Patch
M src/compiler/frame.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +7 lines, -12 lines 0 comments Download
M src/compiler/gap-resolver.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 13 chunks +94 lines, -32 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +77 lines, -27 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 2 3 4 5 6 7 12 1 chunk +5 lines, -12 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 5 6 7 5 chunks +70 lines, -123 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/move-optimizer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +18 lines, -5 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 5 6 7 8 9 10 13 chunks +29 lines, -20 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 31 chunks +167 lines, -84 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 2 3 4 5 6 7 5 chunks +13 lines, -12 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +27 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -2 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcarney
ptal
5 years, 7 months ago (2015-04-29 13:43:56 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/1087793002/diff/290001/src/compiler/instruction.cc File src/compiler/instruction.cc (right): https://codereview.chromium.org/1087793002/diff/290001/src/compiler/instruction.cc#newcode76 src/compiler/instruction.cc:76: if (FLAG_turbo_trace_allocated_types) { Do we need the flag? ...
5 years, 7 months ago (2015-04-29 14:12:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087793002/310001
5 years, 7 months ago (2015-04-29 14:22:00 UTC) #6
commit-bot: I haz the power
Committed patchset #17 (id:310001)
5 years, 7 months ago (2015-04-29 14:46:14 UTC) #7
commit-bot: I haz the power
Patchset 17 (id:??) landed as https://crrev.com/3a025d1ab6437559f86a464767aa03d2d9789f6f Cr-Commit-Position: refs/heads/master@{#28137}
5 years, 7 months ago (2015-04-29 14:46:28 UTC) #8
Michael Achenbach
5 years, 7 months ago (2015-04-29 18:28:02 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #17 id:310001) has been created in
https://codereview.chromium.org/1119483003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks compile on chromium asan and v8
msan:
http://build.chromium.org/p/client.v8/builders/Linux%20ASAN%20Builder/builds/...
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....

Powered by Google App Engine
This is Rietveld 408576698