Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: Source/core/page/PagePopupController.cpp

Issue 1087743002: Support multiple displays for PagePopup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/PagePopupController.cpp
diff --git a/Source/core/page/PagePopupController.cpp b/Source/core/page/PagePopupController.cpp
index f12b3ff82550334df5e70c356b5e5f9b4905fdc0..a3307c0db95d227c233b2f93513146801d656f83 100644
--- a/Source/core/page/PagePopupController.cpp
+++ b/Source/core/page/PagePopupController.cpp
@@ -31,21 +31,24 @@
#include "config.h"
#include "core/page/PagePopupController.h"
+#include "core/page/PagePopup.h"
#include "core/page/PagePopupClient.h"
#include "platform/text/PlatformLocale.h"
#include "public/platform/Platform.h"
namespace blink {
-PagePopupController::PagePopupController(PagePopupClient* client)
- : m_popupClient(client)
+PagePopupController::PagePopupController(PagePopup* popup, PagePopupClient* client)
+ : m_popup(popup)
+ , m_popupClient(client)
{
+ ASSERT(popup);
tkent 2015/04/14 11:09:32 nit: So, the argument and m_popup should be |PageP
keishi 2015/04/14 11:17:45 Done.
ASSERT(client);
}
-PassRefPtrWillBeRawPtr<PagePopupController> PagePopupController::create(PagePopupClient* client)
+PassRefPtrWillBeRawPtr<PagePopupController> PagePopupController::create(PagePopup* popup, PagePopupClient* client)
{
- return adoptRefWillBeNoop(new PagePopupController(client));
+ return adoptRefWillBeNoop(new PagePopupController(popup, client));
}
void PagePopupController::setValueAndClosePopup(int numValue, const String& stringValue)
@@ -119,4 +122,10 @@ void PagePopupController::histogramEnumeration(const String& name, int sample, i
blink::Platform::current()->histogramEnumeration(name.utf8().data(), sample, boundaryValue);
}
+void PagePopupController::setWindowRect(int x, int y, int width, int height)
+{
+ if (m_popup)
+ m_popup->setWindowRect(IntRect(x, y, width, height));
+}
+
}

Powered by Google App Engine
This is Rietveld 408576698