Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1087683002: Remove <> in bisect output. (Closed)

Created:
5 years, 8 months ago by qyearsley
Modified:
5 years, 8 months ago
Reviewers:
prasadv
CC:
chromium-reviews, auto-bisect-reviews_chromium.org, chrisphan, RobertoCN
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove <> in bisect output. When the bisect output text gets added to the perf dashboard, the <> characters shouldn't be there. Ideally the perf dashboard should probably escape these characters before adding it to the quick-logger, but it's also easy to just remove them here. Committed: https://crrev.com/d8eebb033032713b862e7ff222cdb924c9638b83 Cr-Commit-Position: refs/heads/master@{#327063}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Shorten lines to less than 80 columns. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tools/auto_bisect/bisect_printer.py View 1 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
qyearsley
5 years, 8 months ago (2015-04-13 23:14:56 UTC) #2
prasadv
lgtm
5 years, 8 months ago (2015-04-13 23:19:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087683002/1
5 years, 8 months ago (2015-04-14 00:19:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56074)
5 years, 8 months ago (2015-04-14 00:57:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087683002/1
5 years, 8 months ago (2015-04-27 02:39:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59135)
5 years, 8 months ago (2015-04-27 02:51:31 UTC) #11
prasadv
https://codereview.chromium.org/1087683002/diff/1/tools/auto_bisect/bisect_printer.py File tools/auto_bisect/bisect_printer.py (right): https://codereview.chromium.org/1087683002/diff/1/tools/auto_bisect/bisect_printer.py#newcode67 tools/auto_bisect/bisect_printer.py:67: 2. $ git try -b bot-name --svn_repo='svn://svn.chromium.org/chrome-try/try-perf' Getting presubmit ...
5 years, 8 months ago (2015-04-27 17:11:35 UTC) #12
qyearsley
On 2015/04/27 17:11:35, prasadv wrote: > https://codereview.chromium.org/1087683002/diff/1/tools/auto_bisect/bisect_printer.py > File tools/auto_bisect/bisect_printer.py (right): > > https://codereview.chromium.org/1087683002/diff/1/tools/auto_bisect/bisect_printer.py#newcode67 > ...
5 years, 8 months ago (2015-04-27 17:17:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087683002/20001
5 years, 8 months ago (2015-04-27 17:24:04 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 17:33:35 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 17:34:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8eebb033032713b862e7ff222cdb924c9638b83
Cr-Commit-Position: refs/heads/master@{#327063}

Powered by Google App Engine
This is Rietveld 408576698