Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: tools/auto_bisect/bisect_printer.py

Issue 1087683002: Remove <> in bisect output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """This file contains printing-related functionality of the bisect.""" 5 """This file contains printing-related functionality of the bisect."""
6 6
7 import datetime 7 import datetime
8 import re 8 import re
9 9
10 from bisect_results import BisectResults 10 from bisect_results import BisectResults
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 REPRO_STEPS_LOCAL = """ 57 REPRO_STEPS_LOCAL = """
58 ==== INSTRUCTIONS TO REPRODUCE ==== 58 ==== INSTRUCTIONS TO REPRODUCE ====
59 To run locally: 59 To run locally:
60 - Use the test command given under 'BISECT JOB RESULTS' above. 60 - Use the test command given under 'BISECT JOB RESULTS' above.
61 - Consider using a profiler. Pass --profiler=list to list available profilers. 61 - Consider using a profiler. Pass --profiler=list to list available profilers.
62 """ 62 """
63 63
64 REPRO_STEPS_TRYJOB = """ 64 REPRO_STEPS_TRYJOB = """
65 To reproduce on a performance try bot: 65 To reproduce on a performance try bot:
66 1. Edit run-perf-test.cfg 66 1. Edit run-perf-test.cfg
67 2. $ git try -b <bot> --svn_repo='svn://svn.chromium.org/chrome-try/try-perf' 67 2. $ git try -b bot-name --svn_repo='svn://svn.chromium.org/chrome-try/try-perf '
prasadv 2015/04/27 17:11:35 Getting presubmit error, please fix this
68 68
69 Notes: 69 Notes:
70 a) Follow the in-file instructions in run-perf-test.cfg. 70 a) Follow the in-file instructions in run-perf-test.cfg.
71 b) run-perf-test.cfg is under tools/ or under third_party/WebKit/Tools. 71 b) run-perf-test.cfg is under tools/ or under third_party/WebKit/Tools.
72 c) Do your edits preferably under a new git branch. 72 c) Do your edits preferably under a new git branch.
73 d) --browser=release and --browser=android-chromium-testshell are supported 73 d) --browser=release and --browser=android-chromium-testshell are supported
74 depending on the platform (desktop|android). 74 depending on the platform (desktop|android).
75 e) Strip any src/ directories from the head of relative path names. 75 e) Strip any src/ directories from the head of relative path names.
76 f) Make sure to use the appropriate bot on step 3. 76 f) Make sure to use the appropriate bot on step 3.
77 77
78 For more details please visit 78 For more details please visit
79 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots""" 79 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots"""
80 80
81 REPRO_STEPS_TRYJOB_TELEMETRY = """ 81 REPRO_STEPS_TRYJOB_TELEMETRY = """
82 To reproduce on a performance try bot: 82 To reproduce on a performance try bot:
83 %(command)s 83 %(command)s
84 (Where <bot-name> comes from tools/perf/run_benchmark --browser=list) 84 (Where bot-name comes from tools/perf/run_benchmark --browser=list)
85 85
86 For more details please visit 86 For more details please visit
87 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots 87 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots
88 """ 88 """
89 89
90 90
91 class BisectPrinter(object): 91 class BisectPrinter(object):
92 92
93 def __init__(self, opts, depot_registry): 93 def __init__(self, opts, depot_registry):
94 self.opts = opts 94 self.opts = opts
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 336
337 This message includes the command used to run the test. 337 This message includes the command used to run the test.
338 """ 338 """
339 command = '$ ' + self.opts.command 339 command = '$ ' + self.opts.command
340 if bisect_utils.IsTelemetryCommand(self.opts.command): 340 if bisect_utils.IsTelemetryCommand(self.opts.command):
341 command += ('\nAlso consider passing --profiler=list to see available ' 341 command += ('\nAlso consider passing --profiler=list to see available '
342 'profilers.') 342 'profilers.')
343 print REPRO_STEPS_LOCAL 343 print REPRO_STEPS_LOCAL
344 if bisect_utils.IsTelemetryCommand(self.opts.command): 344 if bisect_utils.IsTelemetryCommand(self.opts.command):
345 telemetry_command = re.sub(r'--browser=[^\s]+', 345 telemetry_command = re.sub(r'--browser=[^\s]+',
346 '--browser=<bot-name>', 346 '--browser=bot-name',
347 command) 347 command)
348 print REPRO_STEPS_TRYJOB_TELEMETRY % {'command': telemetry_command} 348 print REPRO_STEPS_TRYJOB_TELEMETRY % {'command': telemetry_command}
349 else: 349 else:
350 print REPRO_STEPS_TRYJOB 350 print REPRO_STEPS_TRYJOB
351 351
352 def _PrintOtherRegressions(self, other_regressions): 352 def _PrintOtherRegressions(self, other_regressions):
353 """Prints a section of the results about other potential regressions.""" 353 """Prints a section of the results about other potential regressions."""
354 print 354 print
355 print 'Other regressions may have occurred:' 355 print 'Other regressions may have occurred:'
356 self._PrintTableRow([8, 70, 10], ['Depot', 'Range', 'Confidence']) 356 self._PrintTableRow([8, 70, 10], ['Depot', 'Range', 'Confidence'])
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 406
407 @staticmethod 407 @staticmethod
408 def _PrintWarnings(warnings): 408 def _PrintWarnings(warnings):
409 """Prints a list of warning strings if there are any.""" 409 """Prints a list of warning strings if there are any."""
410 if not warnings: 410 if not warnings:
411 return 411 return
412 print 412 print
413 print 'WARNINGS:' 413 print 'WARNINGS:'
414 for w in set(warnings): 414 for w in set(warnings):
415 print ' ! %s' % w 415 print ' ! %s' % w
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698