Chromium Code Reviews
Help | Chromium Project | Sign in
(52)

Issue 10876054: MIPS: Cleanup handling of shifts: SHR can deoptimize only when its a shift by 0, all other shift ne… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by palfia
Modified:
2 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Cleanup handling of shifts: SHR can deoptimize only when its a shift by 0, all other shift never deoptimize. Port r12373 (9fdde2ad) Original commit message: Fix DoDeferredNumberTagU to keep the value in xmm1 instead of xmm0 on x64. xmm0 is not saved across runtime call on x64 because MacroAssembler::EnterExitFrameEpilogue preserves only allocatable XMM registers unlike on ia32 where it preserves all registers. Cleanup handling of shifts: SHR can deoptimize only when its a shift by 0, all other shift never deoptimize. Fix type inference for i-to-t change instruction. On X64 this ensures that write-barrier is generated correctly. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12831

Patch Set 1 #

Patch Set 2 : Rebased on r12414 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/mips/lithium-mips.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download
Trybot results:
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 3 (0 generated)
palfia
This patch requires the following CL to be landed first: https://chromiumcodereview.appspot.com/10874047
2 years, 11 months ago (2012-08-23 23:07:15 UTC) #1
palfia
Rebased on r12414
2 years, 11 months ago (2012-08-30 22:37:52 UTC) #2
danno
2 years, 9 months ago (2012-10-29 15:08:38 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f