Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1087283003: Whitelist more license types for naitve_client/toolchain (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_breakpad_arm
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist more license types for naitve_client/toolchain Recently we started pulling in the arm_trusted 'toolchain' which is actually a small linux sysroot image so it contains all kinds of licenses in header files. This was the cause of a recent revert of NaCl DEPS roll: https://codereview.chromium.org/1089163003 BUG=none Committed: https://crrev.com/be2c96140a2a08389849e05049217e9ac421d79f Cr-Commit-Position: refs/heads/master@{#325351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/checklicenses/checklicenses.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
5 years, 8 months ago (2015-04-15 17:50:54 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 8 months ago (2015-04-15 23:53:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087283003/1
5 years, 8 months ago (2015-04-15 23:54:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 23:59:12 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 00:00:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be2c96140a2a08389849e05049217e9ac421d79f
Cr-Commit-Position: refs/heads/master@{#325351}

Powered by Google App Engine
This is Rietveld 408576698