Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1089163003: Revert of NaCl: Update revision in DEPS, bd095c3 -> 8e69819 (Closed)

Created:
5 years, 8 months ago by bartfab (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, Derek Schuff, hidehiko, JF, jvoung (off chromium), native-client-reviews_googlegroups.com, petarj, Petr Hosek, shinyak, teravest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, bd095c3 -> 8e69819 (patchset #1 id:1 of https://codereview.chromium.org/1080363002/) Reason for revert: Breaks check_licenses on Linux: Using base directory: src Checking: src 'native_client/toolchain/linux_x86/arm_trusted/usr/include/X11/Xwindows.h' has non-whitelisted license 'BSD MIT/X11 (BSD like)' 'native_client/toolchain/linux_x86/arm_trusted/usr/include/X11/Xwinsock.h' has non-whitelisted license 'BSD MIT/X11 (BSD like)' 'native_client/toolchain/linux_x86/arm_trusted/usr/include/gdk-pixbuf-2.0/gdk-pixbuf-xlib/gdk-pixbuf-xlibrgb.h' has non-whitelisted license 'MPL (v1.1) LGPL (unversioned/unknown version)' Original issue's description: > NaCl: Update revision in DEPS, bd095c3 -> 8e69819 > > This pulls in the following Native Client changes: > > 36f7841: (petarj@mips.com) [MIPS] Change TEST_IS_LOCK_FREE for 64bit types > c827ec5: (dschuff@chromium.org) Add torture test configs for nacl-clang > 7005393: (dschuff@chromium.org) Add missing EH failures exclusion file for clang > 9b89306: (teravest@chromium.org) Revert of Remove NACL_BUILD_ARCH_MAP (patchset #1 id:1 of https://codereview.chromium.org/1039253003/) > 69c5742: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > 57f974d: (dschuff@chromium.org) Update and triage gcc torture known failures > 10a7211: (shinyak@chromium.org) Check archive on Windows. > da6385f: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS > 0a06a29: (jvoung@chromium.org) Make the torture test known failures for PNaCl a bit stricter. > 6a47074: (dschuff@chromium.org) Run compiler_rt test suite on FYI bots > 021d15a: (jvoung@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > 9b7cee1: (sbc@chromium.org) Cleanup libnacl's pthread.h > 3a908f6: (sbc@chromium.org) Add pthead_condattr_* function to libpthread > 002a793: (dschuff@chromium.org) FYI bot script: Fixes for compiler-rt test suite > 5e87ba2: (dschuff@chromium.org) Remove libstdc++ tests from toolchain_tests > 4d31bac: (dschuff@chromium.org) Fix breakage from 5e87ba2d2c3376efcec763954b5cb81c332d20d1 > d25fdca: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS > 0ebde97: (dschuff@chromium.org) Remove libstdc++ support from PNaCl toolchain > 9c667ae: (dschuff@chromium.org) Update revision for PNaCl > 2ef8b63: (dschuff@chromium.org) Run ARM tests first on the PNaCl toolchain linux64 bot > 40b7e45: (dschuff@chromium.org) Run memcpy_move_set test with and without -fno-builtin > 11953a3: (phosek@chromium.org) Use depot_tools version of Git on Windows for toolchain build > 6863b50: (sbc@chromium.org) Add 'arm_trusted' to the 'nacl_core_sdk' package list > 4dfff0b: (jvoung@chromium.org) Have CMake LLVM build share CFLAGS/CXXFLAGS with autoconf (e.g., libc++ flags). > 47e9502: (hidehiko@chromium.org) Non-SFI mode: Small update for nacl_helper_nonsfi. > 8e69819: (sbc@chromium.org) Add O_EXCL support to sel_ldr open syscall > > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/bd095c3ad5f1f25a9c6f44b7f38cec89383a5c33..8e6981959f76f5480f74b2b4819d3b260b1b2062 > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build > > Committed: https://crrev.com/00471ef5d3d886d71b022ad6eaac317e6c9d5e08 > Cr-Commit-Position: refs/heads/master@{#325177} TBR=dschuff@chromium.org,mseaborn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/48b200b8aa94d599a19c2736c1f52ddc67e16140 Cr-Commit-Position: refs/heads/master@{#325207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bartfab (slow)
Created Revert of NaCl: Update revision in DEPS, bd095c3 -> 8e69819
5 years, 8 months ago (2015-04-15 07:52:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089163003/1
5 years, 8 months ago (2015-04-15 07:53:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 07:54:32 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 07:55:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48b200b8aa94d599a19c2736c1f52ddc67e16140
Cr-Commit-Position: refs/heads/master@{#325207}

Powered by Google App Engine
This is Rietveld 408576698