Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 108723008: Remove some confusing code from ToplevelWindowEventHandler::HandleMousePressed() (Closed)

Created:
6 years, 12 months ago by pkotwicz
Modified:
6 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ToplevelWindowEventHandler::HandleMousePressed() has some comments about only handling events post target. Those comments are untrue so remove them. It is also non trivial to get the originally desired behavior, namely getting mouse events to HTML elements with the "-webkit-app-region" CSS style applied. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243439

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/events/event_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/event_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
Ben can you please take a look? I think you initially added this code to ...
6 years, 12 months ago (2013-12-25 02:30:15 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-06 17:50:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/108723008/30001
6 years, 11 months ago (2014-01-07 09:52:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242325
6 years, 11 months ago (2014-01-07 12:09:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/108723008/30001
6 years, 11 months ago (2014-01-07 16:36:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242527
6 years, 11 months ago (2014-01-07 19:56:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/108723008/30001
6 years, 11 months ago (2014-01-07 21:13:06 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 00:09:34 UTC) #8
Message was sent while issue was closed.
Change committed as 243439

Powered by Google App Engine
This is Rietveld 408576698