ash/wm/toplevel_window_event_handler.cc - Issue 108723008: Remove some confusing code from ToplevelWindowEventHandler::HandleMousePressed()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/toplevel_window_event_handler.cc

Issue 108723008: Remove some confusing code from ToplevelWindowEventHandler::HandleMousePressed() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/toplevel_window_event_handler.cc

diff --git a/ash/wm/toplevel_window_event_handler.cc b/ash/wm/toplevel_window_event_handler.cc

index 933c94770c3a5a2fa578db5e16478b141a48af41..4692c4b80386d2fe4767881a6af4aa6482c87b60 100644

--- a/ash/wm/toplevel_window_event_handler.cc

+++ b/ash/wm/toplevel_window_event_handler.cc

@@ -387,9 +387,7 @@ void ToplevelWindowEventHandler::CompleteDrag(DragCompletionStatus status,

void ToplevelWindowEventHandler::HandleMousePressed(

aura::Window* target,

ui::MouseEvent* event) {

- // Move/size operations are initiated post-target handling to give the target

- // an opportunity to cancel this default behavior by returning ER_HANDLED.

- if (ui::EventCanceledDefaultHandling(*event))

+ if (event->phase() != ui::EP_PRETARGET)

return;

// We also update the current window component here because for the

« no previous file with comments | « no previous file | ash/wm/workspace/workspace_event_handler.cc » ('j') | no next file with comments »