Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/modules/console.cc

Issue 108723006: Gin: Fix console module to be varargs again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ad Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/function_template.h.pump ('k') | gin/test/expect.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/console.cc
diff --git a/gin/modules/console.cc b/gin/modules/console.cc
index c7b9aeb4f6cfb6a12ba389c10d085270b19ce8e9..d172373f01df2a0a2d194bfbc866e65f17015087 100644
--- a/gin/modules/console.cc
+++ b/gin/modules/console.cc
@@ -19,7 +19,12 @@ namespace gin {
namespace {
-void Log(const std::vector<std::string>& messages) {
+void Log(Arguments* args) {
+ std::vector<std::string> messages;
+ if (!args->GetRemaining(&messages)) {
+ args->ThrowError();
+ return;
+ }
std::cout << JoinString(messages, ' ') << std::endl;
}
« no previous file with comments | « gin/function_template.h.pump ('k') | gin/test/expect.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698