Towards Decoupling GuestView from Extensions

extensions/browser/guest_view/guest_view_event.h

Index: extensions/browser/guest_view/guest_view_event.h
diff --git a/extensions/browser/guest_view/guest_view_event.h b/extensions/browser/guest_view/guest_view_event.h
new file mode 100644
index 0000000000000000000000000000000000000000..1e31dd455ce63f08c702f5110b88c2eea5371ad4
--- /dev/null
+++ b/extensions/browser/guest_view/guest_view_event.h
@@ -0,0 +1,35 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_EVENT_H_
+#define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_EVENT_H_
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+
+namespace extensions {
+
+class GuestViewBase;
+
+class GuestViewEvent {

[lazyboy, 2015/04/15 02:50:11]

Description of this class.

[Fady Samuel, 2015/04/15 15:14:04]

Done.

+ public:
+  GuestViewEvent(GuestViewBase* guest,
+                 const std::string& name,
+                 scoped_ptr<base::DictionaryValue> args);
+  ~GuestViewEvent();
+
+  void Dispatch(int instance_id);

[lazyboy, 2015/04/15 02:50:11]

Description, also note that this is self destructing.

[Fady Samuel, 2015/04/15 15:14:05]

Done.

+
+private:
+
+  GuestViewBase* const guest_;

[lazyboy, 2015/04/15 02:50:11]

Note lifetime of |this| vs |guest_| and why accessing |guest_| is safe from
here.

[Fady Samuel, 2015/04/15 15:14:04]

Done.

+  const std::string name_;
+  scoped_ptr<base::DictionaryValue> args_;

[lazyboy, 2015/04/15 02:50:11]

DISALLOW_COPY_AND_ASSIGN

[Fady Samuel, 2015/04/15 15:14:04]

Done.

+};
+
+}  // namespace extensions
+
+#endif  // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_EVENT_H_