Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: extensions/browser/guest_view/guest_view_event.h

Issue 1087123002: Towards Decoupling GuestView from Extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_EVENT_H_
6 #define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_EVENT_H_
7
8 #include <string>
9
10 #include "base/memory/scoped_ptr.h"
11 #include "base/values.h"
12
13 namespace extensions {
14
15 class GuestViewBase;
16
17 class GuestViewEvent {
lazyboy 2015/04/15 02:50:11 Description of this class.
Fady Samuel 2015/04/15 15:14:04 Done.
18 public:
19 GuestViewEvent(GuestViewBase* guest,
20 const std::string& name,
21 scoped_ptr<base::DictionaryValue> args);
22 ~GuestViewEvent();
23
24 void Dispatch(int instance_id);
lazyboy 2015/04/15 02:50:11 Description, also note that this is self destructi
Fady Samuel 2015/04/15 15:14:05 Done.
25
26 private:
27
28 GuestViewBase* const guest_;
lazyboy 2015/04/15 02:50:11 Note lifetime of |this| vs |guest_| and why access
Fady Samuel 2015/04/15 15:14:04 Done.
29 const std::string name_;
30 scoped_ptr<base::DictionaryValue> args_;
lazyboy 2015/04/15 02:50:11 DISALLOW_COPY_AND_ASSIGN
Fady Samuel 2015/04/15 15:14:04 Done.
31 };
32
33 } // namespace extensions
34
35 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_EVENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698