Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: content/browser/web_contents/navigation_controller_impl.cc

Issue 10870073: Change how NavigationController reloads transient entries (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove outdated comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/navigation_controller_impl.cc
===================================================================
--- content/browser/web_contents/navigation_controller_impl.cc (revision 153076)
+++ content/browser/web_contents/navigation_controller_impl.cc (working copy)
@@ -248,9 +248,18 @@
void NavigationControllerImpl::ReloadInternal(bool check_for_repost,
ReloadType reload_type) {
- // Reloading a transient entry does nothing.
- if (transient_entry_index_ != -1)
+ if (transient_entry_index_ != -1) {
+ // Interstitials are reloaded by navigating back to their URLs.
Charlie Reis 2012/08/27 17:25:35 Maybe clarify this as "If an interstitial is showi
mmenke 2012/08/27 17:37:03 Done.
+ content::NavigationEntryImpl* active_entry =
+ NavigationEntryImpl::FromNavigationEntry(GetActiveEntry());
+ if (!active_entry)
+ return;
+ LoadURL(active_entry->GetURL(),
+ content::Referrer(),
+ content::PAGE_TRANSITION_RELOAD,
+ active_entry->extra_headers());
return;
+ }
DiscardNonCommittedEntriesInternal();
int current_index = GetCurrentEntryIndex();
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | content/browser/web_contents/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698