Change how NavigationController reloads transient entries

content/browser/web_contents/navigation_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/navigation_controller_impl.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"  // Temporary
 #include "base/string_util.h"
@@ skipping 230 matching lines @@
 }
 void NavigationControllerImpl::ReloadIgnoringCache(bool check_for_repost) {
   ReloadInternal(check_for_repost, RELOAD_IGNORING_CACHE);
 }
 void NavigationControllerImpl::ReloadOriginalRequestURL(bool check_for_repost) {
   ReloadInternal(check_for_repost, RELOAD_ORIGINAL_REQUEST_URL);
 }
 
 void NavigationControllerImpl::ReloadInternal(bool check_for_repost,
                                               ReloadType reload_type) {
-  // Reloading a transient entry does nothing.
-  if (transient_entry_index_ != -1)
+  if (transient_entry_index_ != -1) {
+    // Interstitials are reloaded by navigating back to their URLs.

[Charlie Reis, 2012/08/27 17:25:35]

Maybe clarify this as "If an interstitial is showing, treat a reload as a
navigation to the transient entry's URL."  (I got confused at first, thinking
the interstitial's URL was the data URL for the warning page.)

[mmenke, 2012/08/27 17:37:03]

Done.

+    content::NavigationEntryImpl* active_entry =
+        NavigationEntryImpl::FromNavigationEntry(GetActiveEntry());
+    if (!active_entry)
+      return;
+    LoadURL(active_entry->GetURL(),
+            content::Referrer(),
+            content::PAGE_TRANSITION_RELOAD,
+            active_entry->extra_headers());
     return;
+  }
 
   DiscardNonCommittedEntriesInternal();
   int current_index = GetCurrentEntryIndex();
   // If we are no where, then we can't reload.  TODO(darin): We should add a
   // CanReload method.
   if (current_index == -1) {
     return;
   }
 
   if (g_check_for_repost && check_for_repost &&
@@ skipping 1283 matching lines @@
   for (int i = 0; i < max_index; i++) {
     // When cloning a tab, copy all entries except interstitial pages
     if (source.entries_[i].get()->GetPageType() !=
         content::PAGE_TYPE_INTERSTITIAL) {
       entries_.insert(entries_.begin() + insert_index++,
                       linked_ptr<NavigationEntryImpl>(
                           new NavigationEntryImpl(*source.entries_[i])));
     }
   }
 }