Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 1086873002: Rename NodeRenderingTraversal to LayoutTreeBuilderTraversal (Closed)

Created:
5 years, 8 months ago by hayato
Modified:
5 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, blink-reviews-html_chromium.org, chromiumbugtracker_adobe.com, blink-reviews-style_chromium.org, zoltan1, webcomponents-bugzilla_chromium.org, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename NodeRenderingTraversal to LayoutTreeBuilderTraversal Batch renaming, hoping that we can prevent NodeRenderingTraversal from being used further except for in building a layout tree. If a long name is allowed, LayoutTreeBuilderTraversal would be: DontUseThisTraversalExceptForBuildingLayoutTreeInsteadYouShouldUseComposedTreeTraversal BUG=472973 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193676

Patch Set 1 #

Patch Set 2 : Add missing files #

Patch Set 3 : Rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -133 lines) Patch
M Source/core/core.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ElementResolveContext.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/LayoutTreeBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/LayoutTreeBuilder.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/dom/LayoutTreeBuilderTraversal.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/dom/LayoutTreeBuilderTraversal.cpp View 1 2 5 chunks +9 lines, -7 lines 1 comment Download
M Source/core/dom/Node.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeComputedStyle.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/dom/NodeRenderingTraversal.h View 1 chunk +0 lines, -82 lines 0 comments Download
M Source/core/dom/Text.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeTraversal.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLIElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/HitTestResult.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutListItem.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hayato
PTAL
5 years, 8 months ago (2015-04-14 06:02:51 UTC) #2
tkent
Please fix try bot failures.
5 years, 8 months ago (2015-04-14 06:04:04 UTC) #3
tkent
lgtm
5 years, 8 months ago (2015-04-14 06:06:31 UTC) #4
hayato
Looks further rebasing is needed. Let me upload a new patch.
5 years, 8 months ago (2015-04-14 06:07:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086873002/40001
5 years, 8 months ago (2015-04-14 06:41:00 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193676
5 years, 8 months ago (2015-04-14 08:27:07 UTC) #9
hayato
Looks this CL forgot to remove NodeRenderingTraversal.cpp, which is unintentional. Let me remove it in ...
5 years, 8 months ago (2015-04-15 10:13:27 UTC) #10
hayato
5 years, 8 months ago (2015-04-15 10:36:11 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1086873002/diff/40001/Source/core/dom/LayoutT...
File Source/core/dom/LayoutTreeBuilderTraversal.cpp (right):

https://codereview.chromium.org/1086873002/diff/40001/Source/core/dom/LayoutT...
Source/core/dom/LayoutTreeBuilderTraversal.cpp:57: ASSERT(node.inDocument() ?
!node.document().childNeedsDistributionRecalc() :
!node.childNeedsDistributionRecalc());
Looks this is the result of wrong rebase, which is unintentional.

Let me fix this in follow-up CL.

Powered by Google App Engine
This is Rietveld 408576698