Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1086643003: cps-ir: Register IndexSet calls like other calls in JS codegen. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added two test cases (one currently disabled) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index da111581ca403443c11e4acec84d2a09b83f3d32..6491df609898e276f16ed02af13cbe508c9bef75 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -255,7 +255,8 @@ class CodeGenerator extends tree_ir.StatementVisitor
registry.registerDynamicSetter(selector);
} else {
assert(invariant(CURRENT_ELEMENT_SPANNABLE,
- selector.isCall || selector.isOperator || selector.isIndex,
+ selector.isCall || selector.isOperator ||
+ selector.isIndex || selector.isIndexSet,
message: 'unexpected kind ${selector.kind}'));
// TODO(sigurdm): We should find a better place to register the call.
Selector call = new Selector.callClosureFrom(selector);
« no previous file with comments | « no previous file | tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698