Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1086643003: cps-ir: Register IndexSet calls like other calls in JS codegen. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added two test cases (one currently disabled) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_generator; 5 library code_generator;
6 6
7 import 'glue.dart'; 7 import 'glue.dart';
8 8
9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir; 9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
10 import '../../js/js.dart' as js; 10 import '../../js/js.dart' as js;
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 } 248 }
249 249
250 void registerMethodInvoke(tree_ir.InvokeMethod node) { 250 void registerMethodInvoke(tree_ir.InvokeMethod node) {
251 Selector selector = node.selector; 251 Selector selector = node.selector;
252 if (selector.isGetter) { 252 if (selector.isGetter) {
253 registry.registerDynamicGetter(selector); 253 registry.registerDynamicGetter(selector);
254 } else if (selector.isSetter) { 254 } else if (selector.isSetter) {
255 registry.registerDynamicSetter(selector); 255 registry.registerDynamicSetter(selector);
256 } else { 256 } else {
257 assert(invariant(CURRENT_ELEMENT_SPANNABLE, 257 assert(invariant(CURRENT_ELEMENT_SPANNABLE,
258 selector.isCall || selector.isOperator || selector.isIndex, 258 selector.isCall || selector.isOperator ||
259 selector.isIndex || selector.isIndexSet,
259 message: 'unexpected kind ${selector.kind}')); 260 message: 'unexpected kind ${selector.kind}'));
260 // TODO(sigurdm): We should find a better place to register the call. 261 // TODO(sigurdm): We should find a better place to register the call.
261 Selector call = new Selector.callClosureFrom(selector); 262 Selector call = new Selector.callClosureFrom(selector);
262 registry.registerDynamicInvocation(call); 263 registry.registerDynamicInvocation(call);
263 registry.registerDynamicInvocation(selector); 264 registry.registerDynamicInvocation(selector);
264 } 265 }
265 } 266 }
266 267
267 @override 268 @override
268 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) { 269 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) {
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
623 624
624 @override 625 @override
625 visitFunctionDeclaration(tree_ir.FunctionDeclaration node) { 626 visitFunctionDeclaration(tree_ir.FunctionDeclaration node) {
626 return errorUnsupportedNode(node); 627 return errorUnsupportedNode(node);
627 } 628 }
628 629
629 errorUnsupportedNode(tree_ir.DartSpecificNode node) { 630 errorUnsupportedNode(tree_ir.DartSpecificNode node) {
630 throw "Unsupported node in JS backend: $node"; 631 throw "Unsupported node in JS backend: $node";
631 } 632 }
632 } 633 }
OLDNEW
« no previous file with comments | « no previous file | tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698