Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10866013: Convert the browsing_data pyauto tests to chrome tests. Remove the ClearBrowsingData automation cod… (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 4 months ago
CC:
chromium-reviews, kkania, dhollowa+watch_chromium.org, Nirnimesh, browser-components-watch_chromium.org, anantha, robertshield, dyu1, dennis_jeffrey, markusheintz_, Ilya Sherman
Visibility:
Public.

Description

Convert the browsing_data pyauto tests to chrome tests. Remove the ClearBrowsingData automation code since it's not used anymore. -browsing_data.testClearAutofillData was flaky because it exposed an actual problem in BrowsingDataRemover (it didn't wait for autofill data to be deleted). Fixed BrowsingDataRemover and added a unittest for removing form data along with the other BrowsingDataRemover unit tests. -browsing_data.testClearDownloads was hard to write as a unit test so I added a browser test -database.testDeleteAndUpdateDatabase was also converted to a browser test -the rest of the tests in browsing_data.py had equivalent unit tests in browsing_data_remover_unittest.cc -the clear password calls in the passwords test aren't needed since each test has a fresh profile Also fix a flake in the BrowsingDataRemoverTest harness. The end time needs to be pushed further into the future, since there could be pending writes. BUG=143637, 141443, 95165, 123419 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152782

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : sync and add missing file #

Patch Set 4 : fix flake in unittest harness #

Total comments: 1

Patch Set 5 : fix flake in unittest harness #

Patch Set 6 : fix hang on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -308 lines) Patch
M chrome/browser/autofill/personal_data_manager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 chunks +0 lines, -66 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 5 chunks +26 lines, -1 line 0 comments Download
A chrome/browser/browsing_data/browsing_data_remover_browsertest.cc View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 3 4 5 4 chunks +79 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/database/simple_database.html View 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 2 4 chunks +0 lines, -10 lines 0 comments Download
D chrome/test/functional/browsing_data.py View 1 2 1 chunk +0 lines, -146 lines 0 comments Download
M chrome/test/functional/databases.py View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/test/functional/passwords.py View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/functional/test_utils.py View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 4 months ago (2012-08-22 00:49:36 UTC) #1
Ben Goodger (Google)
8 years, 4 months ago (2012-08-22 15:57:44 UTC) #2
lgtm

http://codereview.chromium.org/10866013/diff/5005/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/browsing_data_remover_unittest.cc (right):

http://codereview.chromium.org/10866013/diff/5005/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_remover_unittest.cc:329:
~RemoveAutofillTester() {
virtual dtor?

Powered by Google App Engine
This is Rietveld 408576698