Issue 108653006: Assert that convertToLength succeeds instead of returning Length(Undefined)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108653006: Assert that convertToLength succeeds instead of returning Length(Undefined) (Closed)

Created:
7 years ago by Timothy Loh

Modified:
7 years ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Web Animations: Assert that convertToLength succeeds instead of returning Length(Undefined) CSSPrimitiveValue::convertToLength should always match one of the cases for conversion, so instead of returning Length(Undefined) if we somehow fail and asserting in the callers we aren't undefined, simply assert we don't fail. BUG=322365 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164041

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -39 lines)			Patch
M	Source/core/css/CSSCalculationValue.cpp	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValueMappings.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/CSSToStyleMap.cpp	View		3 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/css/resolver/FilterOperationResolver.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderConverter.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 2	3 chunks	+2 lines, -7 lines	0 comments	Download
M	Source/core/css/resolver/TransformBuilder.cpp	View		4 chunks	+5 lines, -11 lines	0 comments	Download
M	Source/core/rendering/style/BasicShapes.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/108653006/30001

7 years ago (2013-12-17 23:02:54 UTC) #3

Timothy Loh

7 years ago (2013-12-18 01:58:02 UTC) #5

Message was sent while issue was closed.

On 2013/12/18 00:39:13, I haz the power (commit-bot) wrote:
> Change committed as 164041

Oops, this isn't related to Web Animations as the patch title suggests.

Expand Messages | Collapse Messages

Issue 108653006: Assert that convertToLength succeeds instead of returning Length(Undefined) (Closed)

Description

Patch Set 1 #

Patch Set 2 : removed some uneeded braces #

Patch Set 3 : rebased #

Messages