Source/core/css/CSSPrimitiveValueMappings.h - Issue 108653006: Assert that convertToLength succeeds instead of returning Length(Undefined)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValueMappings.h

Issue 108653006: Assert that convertToLength succeeds instead of returning Length(Undefined) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSPrimitiveValueMappings.h

diff --git a/Source/core/css/CSSPrimitiveValueMappings.h b/Source/core/css/CSSPrimitiveValueMappings.h

index 3f386133793d5f76d7d855d3902bd8385b9c0eec..11a477bea44a2dabb72dd622fa590dc278005b87 100755

--- a/Source/core/css/CSSPrimitiveValueMappings.h

+++ b/Source/core/css/CSSPrimitiveValueMappings.h

@@ -4454,7 +4454,8 @@ template<int supported> Length CSSPrimitiveValue::convertToLength(const CSSToLen

return Length(cssCalcValue()->toCalcValue(conversionData));

if ((supported & FixedConversion) && isViewportPercentageLength())

return viewportPercentageLength();

- return Length(Undefined);

+ ASSERT_NOT_REACHED();

+ return Length(0, Fixed);

}

template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EBufferedRendering e)

« no previous file with comments | « Source/core/css/CSSCalculationValue.cpp ('k') | Source/core/css/resolver/CSSToStyleMap.cpp » ('j') | no next file with comments »