Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: base/process/process.h

Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/process/process_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/process.h
diff --git a/base/process/process.h b/base/process/process.h
index 808baeb1fc6ebdf7a9603b7b9b8d070b37694cdd..114a694abf11b8efb194e83f7d5c4fe6ea172d93 100644
--- a/base/process/process.h
+++ b/base/process/process.h
@@ -102,10 +102,10 @@ class BASE_EXPORT Process {
// On POSIX, if the process has been signaled then |exit_code| is set to -1.
// On Linux this must be a child process, however on Mac and Windows it can be
// any process.
- bool WaitForExit(int* exit_code);
+ bool WaitForExit(int* exit_code = NULL);
Lei Zhang 2015/04/29 07:52:32 This is against the style guide. https://google-st
rvargas (doing something else) 2015/04/30 23:28:26 Right. I didn't mean to have a default argument, j
g.mehndiratt 2015/05/04 06:40:21 On 2015/04/30 23:28:26, rvargas (out of office) wr
// Same as WaitForExit() but only waits for up to |timeout|.
- bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code);
+ bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code = NULL);
// A process is backgrounded when it's priority is lower than normal.
// Return true if this process is backgrounded, false otherwise.
« no previous file with comments | « no previous file | base/process/process_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698