Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods.

base/process/process.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PROCESS_PROCESS_H_
 #define BASE_PROCESS_PROCESS_H_
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/move.h"
@@ skipping 84 matching lines @@
   // be the exit code of the process. If |wait| is true, this method will wait
   // for up to one minute for the process to actually terminate.
   // Returns true if the process terminates within the allowed time.
   // NOTE: On POSIX |exit_code| is ignored.
   bool Terminate(int exit_code, bool wait) const;
 
   // Waits for the process to exit. Returns true on success.
   // On POSIX, if the process has been signaled then |exit_code| is set to -1.
   // On Linux this must be a child process, however on Mac and Windows it can be
   // any process.
-  bool WaitForExit(int* exit_code);
+  bool WaitForExit(int* exit_code = NULL);

[Lei Zhang, 2015/04/29 07:52:32]

This is against the style guide.
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Default_Argu...

You may want to just wait for rvargas to get back to work out what to do here.

[rvargas (doing something else), 2015/04/30 23:28:26]

Right. I didn't mean to have a default argument, just to accept nullptr as a
valid input.

It's going to be a while before I go back so it's better not to wait for me :). 

[g.mehndiratt, 2015/05/04 06:40:21]

On 2015/04/30 23:28:26, rvargas (out of office) wrote:

I will corporate comments.

If u r not available can u tell whom to add for review?

 
   // Same as WaitForExit() but only waits for up to |timeout|.
-  bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code);
+  bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code = NULL);
 
   // A process is backgrounded when it's priority is lower than normal.
   // Return true if this process is backgrounded, false otherwise.
   bool IsProcessBackgrounded() const;
 
   // Set a process as backgrounded. If value is true, the priority of the
   // process will be lowered. If value is false, the priority of the process
   // will be made "normal" - equivalent to default process priority.
   // Returns true if the priority was changed, false otherwise.
   bool SetProcessBackgrounded(bool value);
 
   // Returns an integer representing the priority of a process. The meaning
   // of this value is OS dependent.
   int GetPriority() const;
 
  private:
 #if defined(OS_WIN)
   bool is_current_process_;
   win::ScopedHandle process_;
 #else
   ProcessHandle process_;
 #endif
 };
 
 }  // namespace base
 
 #endif  // BASE_PROCESS_PROCESS_H_