Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: lib/test.dart

Issue 1086083006: Properly set the exit code for failing tests run directly. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « CHANGELOG.md ('k') | test/runner/runner_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/test.dart
diff --git a/lib/test.dart b/lib/test.dart
index 06280430535a467fd0626163374e735aeb9cb9d4..1d420d311eb9a4d5f33e84122a2d4fd1ae9ec672 100644
--- a/lib/test.dart
+++ b/lib/test.dart
@@ -55,8 +55,13 @@ Declarer get _declarer {
path: p.prettyUri(Uri.base),
platform: "VM")
.forPlatform(TestPlatform.vm, os: currentOSGuess);
- // TODO(nweiz): Set the exit code on the VM when issue 6943 is fixed.
- new NoIoCompactReporter([suite], color: true).run();
+
+ new NoIoCompactReporter([suite], color: true).run().then((success) {
+ // TODO(nweiz): Set the exit code on the VM when issue 6943 is fixed.
+ if (success) return;
+ print('');
+ new Future.error("Dummy exception to set exit code.");
+ });
});
return _globalDeclarer;
}
« no previous file with comments | « CHANGELOG.md ('k') | test/runner/runner_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698