Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: test/runner/runner_test.dart

Issue 1086083006: Properly set the exit code for failing tests run directly. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/runner_test.dart
diff --git a/test/runner/runner_test.dart b/test/runner/runner_test.dart
index 5e038127650cbbd3f78813e7e8c3063de60b3c0f..963feaf3fa223b1bbf3c21c14e6358baf7cb32d6 100644
--- a/test/runner/runner_test.dart
+++ b/test/runner/runner_test.dart
@@ -285,6 +285,7 @@ $_usage"""));
"test.dart"
]);
expect(result.stdout, contains("All tests passed!"));
+ expect(result.exitCode, equals(0));
});
// Regression test; this broke in 0.12.0-beta.9.
@@ -332,6 +333,7 @@ $_usage"""));
"test.dart"
]);
expect(result.stdout, contains("Some tests failed."));
+ expect(result.exitCode, isNot(equals(0)));
});
});
« no previous file with comments | « lib/test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698