Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: media/midi/midi_manager.cc

Issue 108603004: [WebMIDI] MIDIManager::create should return non-null object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager.cc
diff --git a/media/midi/midi_manager.cc b/media/midi/midi_manager.cc
index 6d3f1d30b959139aaad7df5237090fc550b7f462..baea8b17a745c014078f77084c853312720adec3 100644
--- a/media/midi/midi_manager.cc
+++ b/media/midi/midi_manager.cc
@@ -12,7 +12,7 @@ namespace media {
#if !defined(OS_MACOSX) && !defined(OS_WIN)
// TODO(crogers): implement MIDIManager for other platforms.
MIDIManager* MIDIManager::Create() {
- return NULL;
+ return new MIDIManager;
}
#endif
@@ -43,6 +43,17 @@ void MIDIManager::EndSession(MIDIManagerClient* client) {
clients_.erase(i);
}
+void MIDIManager::DispatchSendMIDIData(MIDIManagerClient* client,
+ uint32 port_index,
+ const std::vector<uint8>& data,
+ double timestamp) {
+ NOTREACHED();
+}
+
+bool MIDIManager::Initialize() {
+ return false;
+}
+
void MIDIManager::AddInputPort(const MIDIPortInfo& info) {
input_ports_.push_back(info);
}
« no previous file with comments | « media/midi/midi_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698