Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: media/midi/midi_manager.h

Issue 108603004: [WebMIDI] MIDIManager::create should return non-null object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/midi/midi_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager.h
diff --git a/media/midi/midi_manager.h b/media/midi/midi_manager.h
index f42a40de769a210a54288c08055c7192b7a59675..3b102ec1024b722ebbe4e8aa49f9d449ddbfcb33 100644
--- a/media/midi/midi_manager.h
+++ b/media/midi/midi_manager.h
@@ -65,10 +65,11 @@ class MEDIA_EXPORT MIDIManager {
// |length| is the number of bytes in |data|.
// |timestamp| is the time to send the data, in seconds. A value of 0
// means send "now" or as soon as possible.
+ // The default implementation is for unsupported platforms.
virtual void DispatchSendMIDIData(MIDIManagerClient* client,
uint32 port_index,
const std::vector<uint8>& data,
- double timestamp) = 0;
+ double timestamp);
// input_ports() is a list of MIDI ports for receiving MIDI data.
// Each individual port in this list can be identified by its
@@ -82,7 +83,8 @@ class MEDIA_EXPORT MIDIManager {
protected:
// Initializes the MIDI system, returning |true| on success.
- virtual bool Initialize() = 0;
+ // The default implementation is for unsupported platforms.
+ virtual bool Initialize();
void AddInputPort(const MIDIPortInfo& info);
void AddOutputPort(const MIDIPortInfo& info);
« no previous file with comments | « no previous file | media/midi/midi_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698