Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1085993002: Revert of Use networkingPrivate.startConnect (Closed)

Created:
5 years, 8 months ago by Mark P
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_cellular
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use networkingPrivate.startConnect (patchset #12 id:240001 of https://codereview.chromium.org/1043343002/) Reason for revert: Causes browser_test failure on Win7 bot. https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1) [ RUN ] WebNavigationApiTest.Failures [4444:4508:0414/144708:WARNING:data_reduction_proxy_config.cc(319)] SPDY proxy OFF at startup [4444:2028:0414/144708:ERROR:bluetooth_adapter_win.cc(102)] NOT IMPLEMENTED [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x5) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 2147483650, remote ID 3) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x3B01) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [4444:2028:0414/144709:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframe", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframeNavigation", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[FAIL] cancel: Received unexpected event 'onCompleted':{"frameId":0,"processId":0,"tabId":0,"timeStamp":0,"url":"chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/e.html"} Error at captureEvent (chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:194:17) at chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:219:5 at EventImpl.dispatchToListener (extensions::event_bindings:395:22) at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26) at EventImpl.dispatch_ (extensions::event_bindings:379:35) at dispatchArgs (extensions::event_bindings:247:26) at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistent", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) c:\b\build\slave\win_x64_builder\build\src\chrome\browser\extensions\api\web_navigation\web_navigation_apitest.cc(468): error: Value of: RunExtensionTest("webnavigation/failures") Actual: false Expected: true Failed 1 of 4 tests [4444:2028:0414/144710:ERROR:browser_thread.h(263)] DeleteSoon failed on thread 0 [ FAILED ] WebNavigationApiTest.Failures, where TypeParam = and GetParam() = (2465 ms) Original issue's description: > Use networkingPrivate.startConnect > > This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. > It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. > > BUG=430115 > > Committed: https://crrev.com/e22e5bcbad2cea941993b32e6cc3b082822a42fc > Cr-Commit-Position: refs/heads/master@{#325108} TBR=armansito@chromium.org,michaelpg@chromium.org,pneubeck@chromium.org,stevenjb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=430115 Committed: https://crrev.com/907fe612f5949ef8a6c2fe3bd00ddd1c423f9f20 Cr-Commit-Position: refs/heads/master@{#325145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -204 lines) Patch
M chrome/browser/chromeos/options/network_config_view.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.js View 1 chunk +3 lines, -51 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/networking_private/chromeos/test.js View 1 chunk +0 lines, -13 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 4 chunks +18 lines, -16 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chromeos/network/network_state.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/network/network_state.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chromeos/network/network_state_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chromeos/network/network_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M chromeos/network/onc/onc_translator.h View 2 chunks +2 lines, -8 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 7 chunks +18 lines, -38 lines 0 comments Download
M chromeos/network/onc/onc_translator_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/network/policy_applicator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/device_event_log/device_event_log_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/onc/docs/onc_spec.html View 2 chunks +5 lines, -8 lines 0 comments Download
M ui/chromeos/network/network_connect.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M ui/chromeos/network/network_state_notifier.h View 3 chunks +3 lines, -5 lines 0 comments Download
M ui/chromeos/network/network_state_notifier.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark P
Created Revert of Use networkingPrivate.startConnect
5 years, 8 months ago (2015-04-14 22:54:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085993002/1
5 years, 8 months ago (2015-04-14 22:55:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 22:57:26 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 22:58:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/907fe612f5949ef8a6c2fe3bd00ddd1c423f9f20
Cr-Commit-Position: refs/heads/master@{#325145}

Powered by Google App Engine
This is Rietveld 408576698