chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc - Issue 1085993002: Revert of Use networkingPrivate.startConnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 1085993002: Revert of Use networkingPrivate.startConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_cellular

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/options/network_config_view.cc ('k') | chrome/browser/resources/options/chromeos/internet_detail.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

index 89a201f9dc8436c122cb2ca936c0d5ee4833fced..171e9747ea63a747062747ed84b14a0bd6d4010a 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

@@ -20,8 +20,6 @@

#include "chromeos/dbus/shill_profile_client.h"

#include "chromeos/dbus/shill_service_client.h"

#include "chromeos/login/user_names.h"

-#include "chromeos/network/network_handler.h"

-#include "chromeos/network/network_state_handler.h"

#include "chromeos/network/onc/onc_utils.h"

#include "chromeos/network/portal_detector/network_portal_detector.h"

#include "components/onc/onc_constants.h"

@@ -548,12 +546,6 @@

EXPECT_TRUE(RunNetworkingSubtest("getManagedProperties")) << message_;

}

-IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, GetErrorState) {

- chromeos::NetworkHandler::Get()->network_state_handler()->SetLastErrorForTest(

- kWifi1ServicePath, "TestErrorState");

- EXPECT_TRUE(RunNetworkingSubtest("getErrorState")) << message_;

IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest,

OnNetworksChangedEventConnect) {

EXPECT_TRUE(RunNetworkingSubtest("onNetworksChangedEventConnect"))