Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1085923002: Rename use_nss to use_nss_certs in gyp and grit. (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, cbentzel+watch_chromium.org, michaelpg+watch-options_chromium.org, chromoting-reviews_chromium.org, tfarina, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename use_nss to use_nss_certs in gyp and grit. This matches the gn name and is less confusing with use_openssl and use_openssl_certs both existing. The preprocessor flag will follow in another CL. For now, the old name is still defined, but not used within Chromium. A follow-up CL will remove deprecated use_nss and USE_NSS #defines together which will then cause downstream churn. Though from a grep of known downstreams, the churn seems to be fairly minimal. The removal is split from this CL so that, if we need to revert, the CL to revert is small. BUG=462040 TBR=wez@chromium.org Committed: https://crrev.com/0ee13e37acf707e703a380a9c1a03f0b494dd6a6 Cr-Commit-Position: refs/heads/master@{#325541}

Patch Set 1 #

Patch Set 2 : rebase and add compat name for now #

Patch Set 3 : Ah, variables variables variables #

Patch Set 4 : wrapping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M build/common.gypi View 1 2 3 4 chunks +11 lines, -3 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M crypto/crypto.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M net/net.gyp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/net_common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/cookbook.md View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
davidben
Hopefully this will make the chimera easier to review later. :-)
5 years, 8 months ago (2015-04-14 19:52:02 UTC) #2
tfarina
gn docs lgtm
5 years, 8 months ago (2015-04-14 21:58:27 UTC) #4
Ryan Sleevi
LGTM - but do any buildbots need to be updated? Please make sure infra doesn't ...
5 years, 8 months ago (2015-04-16 01:45:37 UTC) #5
davidben
On 2015/04/16 01:45:37, Ryan Sleevi wrote: > LGTM - but do any buildbots need to ...
5 years, 8 months ago (2015-04-16 04:13:39 UTC) #6
davidben
+thakis for build/OWNERS +dbeam for chrome/browser/resources/options/OWNERS +wez for remoting/OWNERS I've confirmed nothing in the infra ...
5 years, 8 months ago (2015-04-16 16:12:52 UTC) #8
Nico
lgtm
5 years, 8 months ago (2015-04-16 16:49:09 UTC) #9
davidben
Tweaked this, mirroring Nico's suggestion on the preprocessor one, to continue defining use_nss. A follow-up ...
5 years, 8 months ago (2015-04-16 17:58:17 UTC) #10
Dan Beam
lgtm
5 years, 8 months ago (2015-04-16 19:01:24 UTC) #11
davidben
TBRing wez@chromium.org per OWNERS policy, since this is just a global rename. (I always forget ...
5 years, 8 months ago (2015-04-16 22:13:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085923002/60001
5 years, 8 months ago (2015-04-16 22:25:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085923002/60001
5 years, 8 months ago (2015-04-16 22:39:09 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-16 23:23:22 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0ee13e37acf707e703a380a9c1a03f0b494dd6a6 Cr-Commit-Position: refs/heads/master@{#325541}
5 years, 8 months ago (2015-04-16 23:24:24 UTC) #20
Wez
5 years, 8 months ago (2015-04-17 00:47:11 UTC) #21
Message was sent while issue was closed.
Rubbery-stampy LGTM

Powered by Google App Engine
This is Rietveld 408576698