DescriptionRevert of Take GetCharacterFromKeyCode() out behind the barn. (patchset #4 id:60001 of https://codereview.chromium.org/1072193004/)
Reason for revert:
MenuControllerMnemonicTestMnemonicMatch.MnemonicMatch failure in http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/32987
https://code.google.com/p/chromium/issues/detail?id=480638
BUG=480638, 444048
Original issue's description:
> Remove GetCharacterFromKeyCode().
>
> Remaining uses of GetCharacterFromKeyCode() are replaced with
> DomCodeToUsLayoutMeaning() to make explicit that the mapping uses a
> fixed US English layout and not the user's current layout, and to use
> ui::DomCode in preference to the legacy Windows-based ui::KeyboardCode.
>
> BUG=444048
>
> Committed: https://crrev.com/121b8680676123f617ebc69770cbb114c030fbd3
> Cr-Commit-Position: refs/heads/master@{#326553}
TBR=sadrul@chromium.org,wez@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444048
Committed: https://crrev.com/6ea0348f382307d1a1d49b0675cbb1087189eb22
Cr-Commit-Position: refs/heads/master@{#326799}
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|