Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1085733007: Revert of Take GetCharacterFromKeyCode() out behind the barn. (Closed)

Created:
5 years, 8 months ago by kpschoedel
Modified:
5 years, 8 months ago
Reviewers:
sadrul, jam, Wez
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, tdresser+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Take GetCharacterFromKeyCode() out behind the barn. (patchset #4 id:60001 of https://codereview.chromium.org/1072193004/) Reason for revert: MenuControllerMnemonicTestMnemonicMatch.MnemonicMatch failure in http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/32987 https://code.google.com/p/chromium/issues/detail?id=480638 BUG=480638, 444048 Original issue's description: > Remove GetCharacterFromKeyCode(). > > Remaining uses of GetCharacterFromKeyCode() are replaced with > DomCodeToUsLayoutMeaning() to make explicit that the mapping uses a > fixed US English layout and not the user's current layout, and to use > ui::DomCode in preference to the legacy Windows-based ui::KeyboardCode. > > BUG=444048 > > Committed: https://crrev.com/121b8680676123f617ebc69770cbb114c030fbd3 > Cr-Commit-Position: refs/heads/master@{#326553} TBR=sadrul@chromium.org,wez@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444048 Committed: https://crrev.com/6ea0348f382307d1a1d49b0675cbb1087189eb22 Cr-Commit-Position: refs/heads/master@{#326799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -29 lines) Patch
M content/renderer/render_view_browsertest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/keycodes/dom_us_layout_data.h View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.h View 3 chunks +11 lines, -3 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.cc View 2 chunks +243 lines, -5 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/menu/menu_event_dispatcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kpschoedel
Created Revert of Take GetCharacterFromKeyCode() out behind the barn.
5 years, 8 months ago (2015-04-24 15:13:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085733007/1
5 years, 8 months ago (2015-04-24 15:13:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 15:15:05 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 15:16:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ea0348f382307d1a1d49b0675cbb1087189eb22
Cr-Commit-Position: refs/heads/master@{#326799}

Powered by Google App Engine
This is Rietveld 408576698