Remove a duplicate test in LayoutTests/svg/W3C-SVG-1.1

Remove a duplicate test (pservers-grad-17-b.svg) in LayoutTests/svg/W3C-SVG-1.1

W3C-SVG-1.1-SE contains the newer version of test cases.

BUG=477550
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197777

[m.azam, 2015-04-17 14:40:26]

m.azam@samsung.com changed reviewers:
+ pdr@chromium.org

[m.azam, 2015-04-17 14:40:27]

I have compared W3C-SVG-1.1 and W3C-SVG-1.1-SE folders and found that below
files are duplicate tests
1.styling-css-04-f.svg
2.text-intro-02-b.svg
3.text-intro-05-t.svg
4.pservers-grad-17-b.svg
5.filters-felem-01-b.svg

But W3C-SVG-1.1-SE directory are the newest official tests.

BUG=477550

Please review the code

[pdr., 2015-04-18 03:04:23]

On 2015/04/17 at 14:40:27, m.azam wrote:
> I have compared W3C-SVG-1.1 and W3C-SVG-1.1-SE folders and found that below
files are duplicate tests
> 1.styling-css-04-f.svg
> 2.text-intro-02-b.svg
> 3.text-intro-05-t.svg
> 4.pservers-grad-17-b.svg
> 5.filters-felem-01-b.svg
> 
> But W3C-SVG-1.1-SE directory are the newest official tests.
> 
> BUG=477550
> 
> Please review the code

Overall this looks pretty good. I went through each one and confirmed these
tests are fine to remove.

Please remove the following from your change description:
---------8<----------
We should remove exact duplicate tests because they just take up time on the
bots.

Here's a list of duplicate names. These need to be checked by hand to make sure
they are real duplicates. I'm making this as GoodFirstBug for new contributors
but please split this task into a few patches (maybe 5 tests per patch).
---------8<----------


Change the first line of the change description and the patch title to be:
Remove 5 duplicate tests in LayoutTests/svg/W3C-SVG-1.1/


Wrap the change description at 72 characters.


Lastly, we'll need to remove the expectations as well. For filters-felem-01-b,
delete the following:
./LayoutTests/platform/android/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
./LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
./LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
./LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
./LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
./LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
./LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
./LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
./LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
./LayoutTests/svg/W3C-SVG-1.1/filters-felem-01-b-w3c.png

(similarly for the others).

[m.azam, 2015-04-20 05:26:15]

On 2015/04/18 03:04:23, pdr (OOO April 18th to 22nd) wrote:

Review Comments have been added, please review

[m.azam, 2015-04-21 12:06:21]

Patchset #3 (id:40001) has been deleted

[pdr., 2015-04-24 04:07:44]

On 2015/04/20 at 05:26:15, m.azam wrote:
> On 2015/04/18 03:04:23, pdr (OOO April 18th to 22nd) wrote:
> 
> Review Comments have been added, please review

Looking much better!

Please read my review more closely next time. You still need to update your
change description to wrap at 72 characters:
I have compared W3C-SVG-1.1 and W3C-SVG-1.1-SE folders and found that
below files are duplicate tests.

Similarly, you need to update the title (the first line in the change
description and the title in this tool):
Remove 3 duplicate tests in LayoutTests/svg/W3C-SVG-1.1


Unfortunately I noticed the text tests are actually a bit different (see my
comment in https://codereview.chromium.org/1093373002). Lets just update the
following tests in this patch, and handle the text ones in a separate patch:
1. styling-css-04-f.svg
2. pservers-grad-17-b.svg
3. filters-felem-01-b.svg

[m.azam, 2015-04-24 05:33:36]

PTAL

[pdr., 2015-04-25 02:37:49]

On 2015/04/24 at 05:33:36, m.azam wrote:
> PTAL

The actual patch looks good now but we still need to clean up that change
description (yours has random letters capitalized). Lets change your description
to exactly this:
------------8<----------
Remove 3 duplicate tests in LayoutTests/svg/W3C-SVG-1.1

I have compared the W3C-SVG-1.1 and W3C-SVG-1.1-SE folders and found
that the files below are duplicate tests:
1. styling-css-04-f.svg
2. pservers-grad-17-b.svg
3. filters-felem-01-b.svg

W3C-SVG-1.1-SE contains the newer version of test cases.

BUG=477550
------------8<----------


The title of this patch is still:
We should remove exact duplicate tests because they just take up time on the
bots.
Lets change it to:
Remove 3 duplicate tests in LayoutTests/svg/W3C-SVG-1.1

After that we'll be good to go. Just reply with "PTAL" and I'll click the
buttons so this commits.

[m.azam, 2015-04-25 09:00:37]

On 2015/04/25 02:37:49, pdr wrote:

PTAL

[m.azam, 2015-04-27 04:36:40]

On 2015/04/25 09:00:37, m.azam wrote:

PTAL
Let me know if any other changes are required

[pdr., 2015-04-27 21:02:14]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-04-27 21:02:14]

lgtm

[commit-bot: I haz the power, 2015-04-27 21:03:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085583003/60001

[commit-bot: I haz the power, 2015-04-27 21:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 21:06:59]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/53609)

[Laszlo Gombos, 2015-05-19 04:13:03]

l.gombos@chromium.org changed reviewers:
+ l.gombos@chromium.org

[Laszlo Gombos, 2015-05-19 04:13:04]

Mohammad, can you rebase the CL so that it applies to the latest open source
version ?

[m.azam, 2015-06-18 13:37:53]

On 2015/05/19 04:13:04, Laszlo Gombos wrote:

I think the CL was already applied

[lgombos, 2015-06-18 20:19:21]

On 2015/06/18 13:37:53, m.azam wrote:
> On 2015/05/19 04:13:04, Laszlo Gombos wrote:

> I think the CL was already applied

I think we still have 2 copies of pservers-grad-17-b.svg, which your patch
removes. It seems to me we should still land that part.

[lgombos, 2015-06-18 21:18:09]

l.gombos@samsung.com changed reviewers:
+ l.gombos@samsung.com
- l.gombos@chromium.org

[m.azam, 2015-06-23 13:57:30]

PTAL

[lgombos, 2015-06-24 14:46:30]

The CQ bit was checked by l.gombos@samsung.com to run a CQ dry run

[lgombos, 2015-06-24 14:46:30]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1085583003/#ps80001
(title: "Remove 1 duplicate tests in LayoutTests/svg/W3C-SVG-1.1")

[lgombos, 2015-06-24 14:47:03]

The CQ bit was unchecked by l.gombos@samsung.com

[commit-bot: I haz the power, 2015-06-24 14:47:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085583003/80001

[lgombos, 2015-06-24 21:09:02]

The CQ bit was checked by l.gombos@samsung.com

[commit-bot: I haz the power, 2015-06-24 21:09:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085583003/80001

[lgombos, 2015-06-24 21:09:19]

The CQ bit was unchecked by l.gombos@samsung.com

[lgombos, 2015-06-24 21:10:52]

The CQ bit was checked by l.gombos@samsung.com

[commit-bot: I haz the power, 2015-06-24 21:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085583003/80001

[commit-bot: I haz the power, 2015-06-24 21:12:30]

Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197777