Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 108543003: Consistently use AtomicString for namespaceURI / prefix (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
Reviewers:
haraken, eseidel
CC:
blink-reviews, shans, eae+blinkwatch, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, rwlbuis, Nils Barth (inactive), Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, Eric Willigers, rjwright, krit, darktears, kojih, jsbell+bindings_chromium.org, Mike Lawther (Google), f(malita), Inactive, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Consistently use AtomicString for namespaceURI / prefix Consistently use AtomicString for namespaceURI / prefix. In particular, Node's lookupPrefix(), lookupNamespaceURI(), lookupNamespacePrefix() now deal with AtomicStrings. This avoids needless creation of Strings when we actually need AtomicStrings. This is one step towards marking the AtomicString(const String&) constructor explicit. R=eseidel, haraken BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163446

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -41 lines) Patch
M Source/bindings/v8/custom/V8CustomXPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Node.cpp View 4 chunks +18 lines, -18 lines 5 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/NativeXPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/NativeXPathNSResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathGrammar.y View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xml/XPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathParser.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/xml/XPathStep.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
https://codereview.chromium.org/108543003/diff/1/Source/core/dom/Node.cpp File Source/core/dom/Node.cpp (right): https://codereview.chromium.org/108543003/diff/1/Source/core/dom/Node.cpp#newcode1476 Source/core/dom/Node.cpp:1476: return elem->namespaceURI(); This returns a const AtomicString& already. https://codereview.chromium.org/108543003/diff/1/Source/core/dom/Node.cpp#newcode1484 ...
7 years ago (2013-12-06 19:05:29 UTC) #1
haraken
LGTM
7 years ago (2013-12-07 01:25:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/108543003/1
7 years ago (2013-12-09 16:31:02 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-09 17:51:28 UTC) #4
Message was sent while issue was closed. 
Change committed as 163446

Powered by Google App Engine
This is Rietveld 408576698