Source/core/xml/XPathGrammar.y - Issue 108543003: Consistently use AtomicString for namespaceURI / prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathGrammar.y

Issue 108543003: Consistently use AtomicString for namespaceURI / prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XPathGrammar.y

diff --git a/Source/core/xml/XPathGrammar.y b/Source/core/xml/XPathGrammar.y

index 6eba2252561610b31207a9b38b982a9e9d4fe81f..f40b3ce9af9ba94922ebbac7ddaf0e45390cca99 100644

--- a/Source/core/xml/XPathGrammar.y

+++ b/Source/core/xml/XPathGrammar.y

@@ -192,8 +192,8 @@ Step:

NAMETEST OptionalPredicateList

{

- String localName;

- String namespaceURI;

+ AtomicString localName;

+ AtomicString namespaceURI;

if (!parser->expandQName(*$1, localName, namespaceURI)) {

parser->m_gotNamespaceError = true;

YYABORT;

@@ -221,8 +221,8 @@ Step:

AxisSpecifier NAMETEST OptionalPredicateList

{