Chromium Code Reviews
Help | Chromium Project | Sign in
(106)

Issue 10854139: Use HttpAuthController in SocketStream (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by bashi1
Modified:
1 year, 7 months ago
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, Yuta Kitamura, Takashi Toyoshima (chromium)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use HttpAuthController in SocketStream

We need to share http auth cache with http stack because WebSocket is a
subresource and chromium won't show the login dialog for subresource
loading. Use HttpAuthController and pass the common http auth cache to
it to solve the issue.

BUG=47069
TEST=net_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155582

Patch Set 1 #

Total comments: 15

Patch Set 2 : #

Total comments: 16

Patch Set 3 : #

Total comments: 10

Patch Set 4 : Add browser test. #

Total comments: 29

Patch Set 5 : #

Patch Set 6 : Fix browser_test #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : Rebased and Skipped added browser test on chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -191 lines) Lint Patch
A chrome/browser/net/proxy_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +118 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments ? errors Download
A + chrome/test/data/http/tests/ws.html View 1 2 3 4 5 2 chunks +3 lines, -10 lines 0 comments ? errors Download
D chrome/test/data/http/tests/wss.html View 1 2 3 4 1 chunk +0 lines, -39 lines 0 comments ? errors Download
M net/http/http_auth_handler_digest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M net/http/http_auth_handler_digest_unittest.cc View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments ? errors Download
M net/socket_stream/socket_stream.h View 1 2 3 6 chunks +6 lines, -9 lines 0 comments ? errors Download
M net/socket_stream/socket_stream.cc View 1 2 3 4 5 6 14 chunks +74 lines, -130 lines 0 comments 0 errors Download
M net/socket_stream/socket_stream_unittest.cc View 1 2 3 2 chunks +114 lines, -0 lines 0 comments ? errors Download
M net/test/base_test_server.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments ? errors Download
M net/test/local_test_server.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M net/tools/testserver/testserver.py View 1 2 3 4 5 6 4 chunks +119 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 57
bashi1
Hi cbentzel, wtc, Could you take a look?
1 year, 8 months ago #1
wtc
Patch set 1 LGTM. I am no longer that familiar with the current HTTP auth ...
1 year, 8 months ago #2
cbentzel (out until April 27)
Added asanka as well - my knowledge is getting increasingly rusty too. A general concern: ...
1 year, 8 months ago #3
bashi1
Thank you for review! https://chromiumcodereview.appspot.com/10854139/diff/1/net/socket_stream/socket_stream.cc File net/socket_stream/socket_stream.cc (right): https://chromiumcodereview.appspot.com/10854139/diff/1/net/socket_stream/socket_stream.cc#newcode713 net/socket_stream/socket_stream.cc:713: return !is_secure() && (proxy_info_.is_http() || ...
1 year, 8 months ago #4
bashi1
On 2012/08/14 19:32:38, cbentzel wrote: > A general concern: I thought the WebSocket code was ...
1 year, 8 months ago #5
cbentzel (out until April 27)
On 2012/08/14 21:49:14, bashik wrote: > On 2012/08/14 19:32:38, cbentzel wrote: > > A general ...
1 year, 8 months ago #6
wtc
Patch set 2 LGTM. https://chromiumcodereview.appspot.com/10854139/diff/1/net/socket_stream/socket_stream.cc File net/socket_stream/socket_stream.cc (right): https://chromiumcodereview.appspot.com/10854139/diff/1/net/socket_stream/socket_stream.cc#newcode713 net/socket_stream/socket_stream.cc:713: return !is_secure() && (proxy_info_.is_http() || ...
1 year, 8 months ago #7
wtc
https://chromiumcodereview.appspot.com/10854139/diff/6001/net/socket_stream/socket_stream_unittest.cc File net/socket_stream/socket_stream_unittest.cc (right): https://chromiumcodereview.appspot.com/10854139/diff/6001/net/socket_stream/socket_stream_unittest.cc#newcode443 net/socket_stream/socket_stream_unittest.cc:443: // proxy. Nit: please add "so the port may ...
1 year, 8 months ago #8
cbentzel (out until April 27)
Do you have something like a browser_test for this? It doesn't seem like the existing ...
1 year, 8 months ago #9
cbentzel (out until April 27)
My high level concern is that I do not believe this will work for WSS ...
1 year, 8 months ago #10
bashi1
Hi wtc, cbentzel, Thank you for review! I'm ooo till Aug 19 so I'll address ...
1 year, 8 months ago #11
bashi1
Thank you for review. We need a proxy server implementation (perhaps in testserver.py) to add ...
1 year, 8 months ago #12
cbentzel (out until April 27)
Have you tested if this works through an NTLM or Negotiate authenticating proxy - they ...
1 year, 8 months ago #13
cbentzel (out until April 27)
Also - I think the browser_tests would be worth it, particularly if there are even ...
1 year, 8 months ago #14
wtc
Patch set 3 LGTM. Please do not check this in until cbentzel is happy with ...
1 year, 8 months ago #15
bashi1
Adding jar@ for chrome/ review. Added a browser test and a simple proxy server for ...
1 year, 8 months ago #16
cbentzel (out until April 27)
On 2012/08/22 08:36:43, bashik wrote: > Adding jar@ for chrome/ review. > > Added a ...
1 year, 8 months ago #17
wtc
Patch set 4 LGTM. I like the new tests! http://codereview.chromium.org/10854139/diff/15001/chrome/browser/net/proxy_browsertest.cc File chrome/browser/net/proxy_browsertest.cc (right): http://codereview.chromium.org/10854139/diff/15001/chrome/browser/net/proxy_browsertest.cc#newcode29 chrome/browser/net/proxy_browsertest.cc:29: ...
1 year, 8 months ago #18
cbentzel (out until April 27)
Why is the Threading mixin required for testserver.py? http://codereview.chromium.org/10854139/diff/15001/chrome/browser/net/proxy_browsertest.cc File chrome/browser/net/proxy_browsertest.cc (right): http://codereview.chromium.org/10854139/diff/15001/chrome/browser/net/proxy_browsertest.cc#newcode99 chrome/browser/net/proxy_browsertest.cc:99: StringPrintf("%s%d%s", ...
1 year, 8 months ago #19
cbentzel (out until April 27)
Also - other than the Digest-related BUG, this generally looks good. Thanks for taking the ...
1 year, 8 months ago #20
wtc
bashi: I prototyped my suggested change to state transition in https://chromiumcodereview.appspot.com/10875022/ because I am worried ...
1 year, 8 months ago #21
bashi1
> We have proxies set up in our office like this - I'll send you ...
1 year, 8 months ago #22
bashi1
On 2012/08/22 22:19:08, wtc wrote: > bashi: I prototyped my suggested change to state transition ...
1 year, 8 months ago #23
Takashi Toyoshima (chromium)
http://codereview.chromium.org/10854139/diff/15001/chrome/test/data/http/tests/ws.html File chrome/test/data/http/tests/ws.html (right): http://codereview.chromium.org/10854139/diff/15001/chrome/test/data/http/tests/ws.html#newcode35 chrome/test/data/http/tests/ws.html:35: setTimeout(timeOutCallback, 3000); Yes. Originally, I intended to realize timeout ...
1 year, 8 months ago #24
bashi1
http://codereview.chromium.org/10854139/diff/15001/chrome/test/data/http/tests/ws.html File chrome/test/data/http/tests/ws.html (right): http://codereview.chromium.org/10854139/diff/15001/chrome/test/data/http/tests/ws.html#newcode35 chrome/test/data/http/tests/ws.html:35: setTimeout(timeOutCallback, 3000); On 2012/08/23 11:27:26, toyoshim wrote: > Yes. ...
1 year, 8 months ago #25
cbentzel (out until April 27)
http://codereview.chromium.org/10854139/diff/15001/chrome/test/data/http/tests/ws.html File chrome/test/data/http/tests/ws.html (right): http://codereview.chromium.org/10854139/diff/15001/chrome/test/data/http/tests/ws.html#newcode35 chrome/test/data/http/tests/ws.html:35: setTimeout(timeOutCallback, 3000); On 2012/08/23 11:53:24, bashik wrote: > On ...
1 year, 8 months ago #26
cbentzel (out until April 27)
LGTM Thank you for cleaning this up and adding all of the tests. The browser ...
1 year, 8 months ago #27
wtc
Patch set 6 LGTM. http://codereview.chromium.org/10854139/diff/29003/net/socket_stream/socket_stream.cc File net/socket_stream/socket_stream.cc (right): http://codereview.chromium.org/10854139/diff/29003/net/socket_stream/socket_stream.cc#newcode911 net/socket_stream/socket_stream.cc:911: } else if (delegate_) { ...
1 year, 8 months ago #28
bashi1
Adding ben@ for chrome/ review. Thank you for review. I noticed that |sock| in testserver.py ...
1 year, 8 months ago #29
bashi1
Hi jar, ben, Could you take a look for chrome/ ?
1 year, 8 months ago #30
Ben Goodger (Google)
jar can review the majority of the chrome stuff. gyp change lgtm ;-)
1 year, 8 months ago #31
jar
On 2012/08/27 15:48:30, Ben Goodger (Google) wrote: > jar can review the majority of the ...
1 year, 8 months ago #32
bashi1
On 2012/08/27 17:52:59, jar wrote: > On 2012/08/27 15:48:30, Ben Goodger (Google) wrote: > > ...
1 year, 8 months ago #33
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/10854139/22006
1 year, 8 months ago #34
I haz the power (commit-bot)
Try job failure for 10854139-22006 (retry) on win for step "runhooks" (clobber build). It's a ...
1 year, 8 months ago #35
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/10854139/22006
1 year, 7 months ago #36
I haz the power (commit-bot)
Try job failure for 10854139-22006 (retry) on linux_chromeos for step "browser_tests". It's a second try, ...
1 year, 7 months ago #37
bashi1
+kuan As for failing the new browser test on chromeos, it seems that chromeos bypasses ...
1 year, 7 months ago #38
cbentzel (out until April 27)
Let's try to keep on ChromeOS. What if you do something like a MappedHostResolver which ...
1 year, 7 months ago #39
kuan
On 2012/08/29 05:05:57, bashik wrote: > +kuan > > As for failing the new browser ...
1 year, 7 months ago #40
bashi1
On 2012/08/29 13:52:30, cbentzel wrote: > Let's try to keep on ChromeOS. What if you ...
1 year, 7 months ago #41
cbentzel (out until April 27)
+eroman Eric - any idea if proxy being bypassed for localhost on ChromeOS makes sense?
1 year, 7 months ago #42
eroman
Not sure exactly the context of this question, but it is pretty common to have ...
1 year, 7 months ago #43
eroman
Not sure exactly the context of this question, but it is pretty common to have ...
1 year, 7 months ago #44
cbentzel (out until April 27)
Sorry - this is a browser_test failure on ChromeOS only where --proxy-server=localhost:4488 or similar is ...
1 year, 7 months ago #45
cbentzel (out until April 27)
Sorry - this is a browser_test failure on ChromeOS only where --proxy-server=localhost:4488 or similar is ...
1 year, 7 months ago #46
cbentzel (out until April 27)
Looking at ChromeOS's ProxyConfigServiceImpl, it looks like the issue may be that --proxy-server flag isn't ...
1 year, 7 months ago #47
cbentzel (out until April 27)
Looking at ChromeOS's ProxyConfigServiceImpl, it looks like the issue may be that --proxy-server flag isn't ...
1 year, 7 months ago #48
bashi1
I think --proxy-server works on chromeos. I can see a login dialog for proxy server ...
1 year, 7 months ago #49
bashi1
I think --proxy-server works on chromeos. I can see a login dialog for proxy server ...
1 year, 7 months ago #50
cbentzel (out until April 27)
OK, sounds like I read the code incorrectly. Thank you for checking. I can dive ...
1 year, 7 months ago #51
cbentzel (out until April 27)
OK, sounds like I read the code incorrectly. Thank you for checking. I can dive ...
1 year, 7 months ago #52
bashi1
Hi cbentzel, As described separately, it's somewhat difficult to make this browser test work on ...
1 year, 7 months ago #53
cbentzel (out until April 27)
On 2012/09/02 23:54:24, bashik wrote: > Hi cbentzel, > > As described separately, it's somewhat ...
1 year, 7 months ago #54
bashi1
Thanks, cbentzel! On 2012/09/07 12:54:16, cbentzel wrote: > On 2012/09/02 23:54:24, bashik wrote: > > ...
1 year, 7 months ago #55
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/10854139/40001
1 year, 7 months ago #56
I haz the power (commit-bot)
1 year, 7 months ago #57
Change committed as 155582
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6