Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1085233004: Moves services implementations out of third_party/mojo_services (Closed)

Created:
5 years, 8 months ago by sky
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, je_julie(Not used), qsr+mojo_chromium.org, plundblad+watch_chromium.org, viettrungluu+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, dcheng, abarth-chromium, yuzo+watch_chromium.org, Aaron Boodman, yzshen+watch_chromium.org, dtseng+watch_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves services implementations out of third_party/mojo_services Most go into components/, with the exception of events and input_events. They are in ui/mojo now. R=ben@chromium.org, jam@chromium.org, jochen@chromium.org TBR=jochen@chromium.org BUG=479353 Committed: https://crrev.com/d866af3aee3eff86fcc93f24d77bef4425b80b5a Cr-Commit-Position: refs/heads/master@{#326535}

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Patch Set 3 : cleanup #

Patch Set 4 : merge #

Patch Set 5 : unnecessary changes #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -5240 lines) Patch
M BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M components/clipboard/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/clipboard/clipboard_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/clipboard_standalone_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/clipboard/public/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/clipboard/public/interfaces/clipboard.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/gles2/BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M components/gles2/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M components/gles2/command_buffer_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M components/gles2/command_buffer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gles2/command_buffer_type_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M components/gles2/command_buffer_type_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gles2/gpu_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/gpu/public/interfaces/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
A + components/gpu/public/interfaces/command_buffer.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/gpu/public/interfaces/context_provider.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/gpu/public/interfaces/gpu.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/gpu/public/interfaces/gpu_capabilities.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/gpu/public/interfaces/viewport_parameter_listener.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 3 chunks +5 lines, -5 lines 0 comments Download
M components/html_viewer/DEPS View 1 2 chunks +7 lines, -1 line 0 comments Download
M components/html_viewer/blink_basic_type_converters.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/blink_input_events_type_converters.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/blink_input_events_type_converters.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_document.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/touch_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_clipboard_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/kiosk_wm/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/kiosk_wm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/kiosk_wm/kiosk_wm.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/native_viewport/BUILD.gn View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M components/native_viewport/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/native_viewport/main.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/native_viewport/native_viewport_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/native_viewport/onscreen_context_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/native_viewport/platform_viewport.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/native_viewport/public/cpp/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A + components/native_viewport/public/cpp/args.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/native_viewport/public/cpp/lib/args.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/native_viewport/public/interfaces/BUILD.gn View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + components/native_viewport/public/interfaces/native_viewport.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M components/surfaces/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/surfaces/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/surfaces/display_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/surfaces/display_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/surfaces/public/interfaces/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/surfaces/public/interfaces/display.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/surfaces/public/interfaces/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/surfaces/public/interfaces/surface_id.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/surfaces/public/interfaces/surfaces.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M components/surfaces/surfaces_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/surfaces/surfaces_service_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/BUILD.gn View 1 2 7 chunks +28 lines, -28 lines 0 comments Download
M components/view_manager/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M components/view_manager/access_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/animation_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/client_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/connection_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/connection_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/display_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/view_manager/display_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/view_manager/gesture_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/gesture_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/gesture_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/ids.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/view_manager/public/cpp/BUILD.gn View 1 2 3 chunks +5 lines, -8 lines 0 comments Download
A + components/view_manager/public/cpp/keys.h View 0 chunks +-1 lines, --1 lines 1 comment Download
A + components/view_manager/public/cpp/keys.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/lib/view.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + components/view_manager/public/cpp/lib/view_manager_client_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/public/cpp/lib/view_manager_client_impl.h View 1 chunk +6 lines, -6 lines 1 comment Download
A + components/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 chunk +11 lines, -11 lines 0 comments Download
A + components/view_manager/public/cpp/lib/view_manager_context.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/view_manager/public/cpp/lib/view_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/lib/view_private.h View 1 chunk +1 line, -1 line 1 comment Download
A + components/view_manager/public/cpp/lib/view_private.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + components/view_manager/public/cpp/tests/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/tests/view_manager_test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/tests/view_manager_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/tests/view_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/view_manager/public/cpp/types.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/public/cpp/util.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/view.h View 1 chunk +8 lines, -8 lines 0 comments Download
A + components/view_manager/public/cpp/view_manager.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/view_manager_client_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/view_manager/public/cpp/view_manager_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/view_manager/public/cpp/view_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/view_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/view_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/view_manager/public/cpp/view_property.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/cpp/view_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/view_manager/public/cpp/view_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/interfaces/BUILD.gn View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + components/view_manager/public/interfaces/animations.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/interfaces/view_manager.mojom View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/view_manager/public/interfaces/view_manager_constants.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/view_manager/scheduled_animation_group.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/scheduled_animation_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/server_view.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/server_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/server_view_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/test_change_tracker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/view_manager/test_change_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/view_manager_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_client_apptest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M components/view_manager/view_manager_service_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/view_manager/view_manager_service_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/view_manager_service_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/window_manager/BUILD.gn View 1 2 4 chunks +14 lines, -14 lines 0 comments Download
M components/window_manager/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/window_manager/basic_focus_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/capture_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/capture_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/focus_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/focus_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/focus_rules.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/window_manager/native_viewport_event_dispatcher_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/window_manager/public/interfaces/BUILD.gn View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
A + components/window_manager/public/interfaces/window_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/window_manager/public/interfaces/window_manager_internal.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/view_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/view_target.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/view_target_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/window_manager_app.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/window_manager/window_manager_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/window_manager/window_manager_apptest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/window_manager/window_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/window_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/window_manager_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/cc/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/cc/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/cc/output_surface_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/geometry/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/geometry/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/geometry/geometry_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/converters/input_events/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/input_events/input_events_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/converters/surfaces/surfaces_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/converters/transform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/transform/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/transform/transform_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/gles2/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/services/network/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/android/native_viewport_application_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo_services/src/accessibility/public/interfaces/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo_services/src/accessibility/public/interfaces/accessibility.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/clipboard/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo_services/src/geometry/public/cpp/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/mojo_services/src/geometry/public/cpp/geometry_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/mojo_services/src/geometry/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo_services/src/geometry/public/interfaces/geometry.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/mojo_services/src/gpu/public/interfaces/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/mojo_services/src/gpu/public/interfaces/command_buffer.mojom View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/mojo_services/src/gpu/public/interfaces/context_provider.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/mojo_services/src/gpu/public/interfaces/gpu.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo_services/src/gpu/public/interfaces/gpu_capabilities.mojom View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/mojo_services/src/gpu/public/interfaces/viewport_parameter_listener.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo_services/src/input_events/public/interfaces/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/mojo_services/src/input_events/public/interfaces/input_event_constants.mojom View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/mojo_services/src/input_events/public/interfaces/input_events.mojom View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/mojo_services/src/input_events/public/interfaces/input_key_codes.mojom View 1 chunk +0 lines, -186 lines 0 comments Download
D third_party/mojo_services/src/native_viewport/public/cpp/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo_services/src/native_viewport/public/cpp/args.h View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/mojo_services/src/native_viewport/public/cpp/lib/args.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/mojo_services/src/native_viewport/public/interfaces/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/mojo_services/src/native_viewport/public/interfaces/native_viewport.mojom View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/mojo_services/src/surfaces/public/interfaces/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/mojo_services/src/surfaces/public/interfaces/display.mojom View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/mojo_services/src/surfaces/public/interfaces/quads.mojom View 1 chunk +0 lines, -212 lines 0 comments Download
D third_party/mojo_services/src/surfaces/public/interfaces/surface_id.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/mojo_services/src/surfaces/public/interfaces/surfaces.mojom View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/BUILD.gn View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/keys.h View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/keys.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc View 1 chunk +0 lines, -589 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_impl.h View 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 chunk +0 lines, -511 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_context.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view_observer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view_private.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/lib/view_private.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/tests/run_all_unittests.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/tests/view_manager_test_suite.h View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/tests/view_manager_test_suite.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc View 1 chunk +0 lines, -884 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/types.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/util.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view.h View 1 chunk +0 lines, -210 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_manager.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_manager_client_factory.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_manager_context.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_manager_delegate.h View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_manager_delegate.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_observer.h View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_property.h View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_tracker.h View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/cpp/view_tracker.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/interfaces/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/interfaces/animations.mojom View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/interfaces/view_manager.mojom View 1 chunk +0 lines, -230 lines 0 comments Download
D third_party/mojo_services/src/view_manager/public/interfaces/view_manager_constants.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/mojo_services/src/window_manager/public/interfaces/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/mojo_services/src/window_manager/public/interfaces/window_manager.mojom View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/mojo_services/src/window_manager/public/interfaces/window_manager_internal.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
A + ui/mojo/events/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
A + ui/mojo/events/input_event_constants.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/mojo/events/input_events.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/mojo/events/input_key_codes.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/mojo/geometry/BUILD.gn View 1 chunk +8 lines, -3 lines 0 comments Download
A + ui/mojo/geometry/geometry.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/mojo/geometry/geometry_util.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
sky
5 years, 8 months ago (2015-04-22 23:33:34 UTC) #1
tfarina
Scott, the CL description says "Most go into components", but there is not Go files ...
5 years, 8 months ago (2015-04-22 23:39:23 UTC) #2
sky
On 2015/04/22 23:39:23, tfarina wrote: > Scott, the CL description says "Most go into components", ...
5 years, 8 months ago (2015-04-22 23:48:12 UTC) #3
tfarina
Sorry, I misread it. "Most go", not "Move go into".
5 years, 8 months ago (2015-04-23 00:00:56 UTC) #4
sky
+jam in case you're around.
5 years, 8 months ago (2015-04-23 00:10:47 UTC) #6
jam
lgtm https://codereview.chromium.org/1085233004/diff/70001/components/view_manager/public/cpp/keys.h File components/view_manager/public/cpp/keys.h (right): https://codereview.chromium.org/1085233004/diff/70001/components/view_manager/public/cpp/keys.h#newcode5 components/view_manager/public/cpp/keys.h:5: #ifndef MOJO_SERVICES_VIEW_MANAGER_PUBLIC_CPP_KEYS_H_ nit: update? https://codereview.chromium.org/1085233004/diff/70001/components/view_manager/public/cpp/lib/view_manager_client_impl.h File components/view_manager/public/cpp/lib/view_manager_client_impl.h (right): ...
5 years, 8 months ago (2015-04-23 15:28:12 UTC) #7
sky
On 2015/04/23 15:28:12, jam wrote: > lgtm > > https://codereview.chromium.org/1085233004/diff/70001/components/view_manager/public/cpp/keys.h > File components/view_manager/public/cpp/keys.h (right): > ...
5 years, 8 months ago (2015-04-23 15:44:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085233004/70001
5 years, 8 months ago (2015-04-23 15:44:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58444)
5 years, 8 months ago (2015-04-23 15:58:11 UTC) #12
sky
The presubmit is wrong, I just reordered some things in html_viewer/DEPS. I'm TBRing jochen for ...
5 years, 8 months ago (2015-04-23 16:11:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085233004/70001
5 years, 8 months ago (2015-04-23 16:11:46 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 8 months ago (2015-04-23 16:20:19 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 16:21:10 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d866af3aee3eff86fcc93f24d77bef4425b80b5a
Cr-Commit-Position: refs/heads/master@{#326535}

Powered by Google App Engine
This is Rietveld 408576698