Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1085033006: Remove RunLocation from web_view_internal.json. (Closed)

Created:
5 years, 8 months ago by Xi Han
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RunLocation from web_view_internal.json. Remove this ducplication, and let the "run_at" property to refer extensionTypes.RunAt. The CL that fixed the complier bug for JSON is: https://codereview.chromium.org/1100333006 BUG=477457 Committed: https://crrev.com/f72b8d7108813712061cc43cbdda1a11f6d5bec5 Cr-Commit-Position: refs/heads/master@{#326830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M extensions/common/api/web_view_internal.json View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xi Han
kalman@: I updated the reference after your fix. Please take a look, thanks.
5 years, 8 months ago (2015-04-24 15:03:29 UTC) #3
not at google - send to devlin
cool! lgtm, fix typo on CL description though ("web_view_interanl.json").
5 years, 8 months ago (2015-04-24 16:31:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085033006/1
5 years, 8 months ago (2015-04-24 17:11:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 17:39:06 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 17:40:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f72b8d7108813712061cc43cbdda1a11f6d5bec5
Cr-Commit-Position: refs/heads/master@{#326830}

Powered by Google App Engine
This is Rietveld 408576698