Make the JSON Schema compiler handle enums declared in other namespaces.

Make the JSON Schema compiler handle enums declared in other namespaces.

BUG=477457
R=rdevlin.cronin@chromium.org

Committed: https://crrev.com/16a9133a26d076f649a7bf402a88c5aa709a45da
Cr-Commit-Position: refs/heads/master@{#326703}

[not at google - send to devlin, 2015-04-23 22:59:50]

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/test/crossref_unittest.cc (right):

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/test/crossref_unittest.cc:25:
TEST(JsonSchemaCompilerCrossrefTest, CrossrefTypePopulateAndToValue) {
This is the only test I'm going to touch. The rest, yeesh.

I renamed CreateTestTypeDictionary --> CreateTestTypeValue because these methods
are named ToValue etc, not ToDictionary etc.

[Devlin, 2015-04-23 23:26:52]

lgtm

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/cc_generator.py (right):

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/cc_generator.py:373: c.Sblock('if (%s != %s%s) {' %
Honestly, we should probably just fully specify every type, and that would save
us from having to make these changes.  But, of course, that's a pain to do.  So
oh well. :)

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/h_generator.py (right):

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/h_generator.py:66: # Hack: we're not generating soft
inclues for tabs and windows, so we need
typo: includes

[not at google - send to devlin, 2015-04-23 23:28:46]

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/cc_generator.py (right):

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/cc_generator.py:373: c.Sblock('if (%s != %s%s) {' %
On 2015/04/23 23:26:51, Devlin wrote:
> Honestly, we should probably just fully specify every type, and that would
save
> us from having to make these changes.  But, of course, that's a pain to do. 
So
> oh well. :)

Hah, yes, that would make things simpler.

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/h_generator.py (right):

https://codereview.chromium.org/1100333006/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/h_generator.py:66: # Hack: we're not generating soft
inclues for tabs and windows, so we need
On 2015/04/23 23:26:51, Devlin wrote:
> typo: includes

Done.

[not at google - send to devlin, 2015-04-23 23:28:51]

The CQ bit was checked by kalman@chromium.org

[not at google - send to devlin, 2015-04-23 23:28:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1100333006/#ps20001
(title: "typo")

[commit-bot: I haz the power, 2015-04-23 23:29:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100333006/20001

[commit-bot: I haz the power, 2015-04-24 00:33:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-24 00:34:34]

Patchset 2 (id:??) landed as
https://crrev.com/16a9133a26d076f649a7bf402a88c5aa709a45da
Cr-Commit-Position: refs/heads/master@{#326703}