Introduce InspectorIdentifiers<> and use it to assign/lookup LocalFrame and DocumentLoader

Introduce InspectorIdentifiers<> and use it to assign/lookup LocalFrame and DocumentLoader

This is the first step towards untangling most agents from non-static Page agent dependency
by extracting mapping between DocumentLoader and LocalFrame and their identifiers into
InspectorIdentifiers similar to how it used to be done with DOMNodeIds.

- explicitly specialize WeakIdentifierMap for GC vs. non-GC types rather than conditionally
    compiling on ENABLE(OILPAN) so that we can use it with Oilpan for non-GC types;
- generalize WeakIdentifierMap to use arbitrary identifier types and generators,
    provide traits for inspector's IdentifierGenerator.
- introduce InspectorIdentifiers<> as a static wrapper around WeakIdentifierMap;

BUG=480341
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194414

[caseq, 2015-04-21 16:46:19]

caseq@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2015-04-21 16:58:12]

I'm wondering why WeakIdentifierMap is a part of core/dom.

[caseq, 2015-04-21 17:35:58]

On 2015/04/21 16:58:12, dgozman wrote:
> I'm wondering why WeakIdentifierMap is a part of core/dom.

This is mostly historical. As discussed offline, I'll move it to platfrom/, but
let's do it with a separate patch.

[pfeldman, 2015-04-23 09:56:19]

pfeldman@chromium.org changed reviewers:
+ yurys@chromium.org
- pfeldman@chromium.org

[caseq, 2015-04-23 10:13:01]

caseq@chromium.org changed reviewers:
+ pfeldman@chromium.org

[yurys, 2015-04-23 10:16:16]

Is there a bug describing the general plan?

[caseq, 2015-04-23 10:31:16]

Just filed bug 480341.

[yurys, 2015-04-24 08:43:35]

lgtm

https://codereview.chromium.org/1085033003/diff/20001/Source/core/dom/DOMNode...
File Source/core/dom/DOMNodeIds.h (right):

https://codereview.chromium.org/1085033003/diff/20001/Source/core/dom/DOMNode...
Source/core/dom/DOMNodeIds.h:22: typedef WeakIdentifierMap<Node> WeakNodeMap;
using

[caseq, 2015-04-24 13:51:42]

The CQ bit was checked by caseq@chromium.org

[caseq, 2015-04-24 13:51:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1085033003/#ps40001
(title: "review comment addressed")

[commit-bot: I haz the power, 2015-04-24 13:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085033003/40001

[commit-bot: I haz the power, 2015-04-24 14:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 14:15:11]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[caseq, 2015-04-24 16:46:49]

The CQ bit was checked by caseq@chromium.org

[caseq, 2015-04-24 16:46:49]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1085033003/#ps60001
(title: "win build error fixed")

[commit-bot: I haz the power, 2015-04-24 16:47:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085033003/60001

[commit-bot: I haz the power, 2015-04-24 19:21:00]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194414